Re: [Qemu-devel] [Qemu-trivial] [PATCH] tcg: mark tcg_out* and tcg_patch* with attribute 'unused'

2014-06-21 Thread Michael Tokarev
07.06.2014 21:08, Peter Maydell wrote: The tcg_out* and tcg_patch* functions are utility routines that may or may not be used by a particular backend; mark them with the 'unused' attribute to suppress spurious warnings if they aren't used. Applied to -trivial, thank you! /mjt

Re: [Qemu-devel] [Qemu-trivial] [PATCH] tcg: mark tcg_out* and tcg_patch* with attribute 'unused'

2014-06-08 Thread Michael Tokarev
07.06.2014 21:08, Peter Maydell wrote: The tcg_out* and tcg_patch* functions are utility routines that may or may not be used by a particular backend; mark them with the 'unused' attribute to suppress spurious warnings if they aren't used. Signed-off-by: Peter Maydell

Re: [Qemu-devel] [Qemu-trivial] [PATCH] tcg: mark tcg_out* and tcg_patch* with attribute 'unused'

2014-06-08 Thread Peter Maydell
On 8 June 2014 13:11, Michael Tokarev m...@tls.msk.ru wrote: 07.06.2014 21:08, Peter Maydell wrote: The tcg_out* and tcg_patch* functions are utility routines that may or may not be used by a particular backend; mark them with the 'unused' attribute to suppress spurious warnings if they aren't

Re: [Qemu-devel] [Qemu-trivial] [PATCH] tcg: mark tcg_out* and tcg_patch* with attribute 'unused'

2014-06-08 Thread Peter Maydell
On 8 June 2014 13:11, Michael Tokarev m...@tls.msk.ru wrote: 07.06.2014 21:08, Peter Maydell wrote: The tcg_out* and tcg_patch* functions are utility routines that may or may not be used by a particular backend; mark them with the 'unused' attribute to suppress spurious warnings if they aren't

Re: [Qemu-devel] [Qemu-trivial] [PATCH] tcg: mark tcg_out* and tcg_patch* with attribute 'unused'

2014-06-08 Thread Richard Henderson
On 06/08/2014 12:04 PM, Peter Maydell wrote: The other approach we could take would be to move these definitions from this .c file into a .h file (tcg-backend-helpers.h ?). Then clang won't complain (it seems to only warn about unused static-inline-functions in .c files, not in .h files).