Re: [Qemu-devel] [Qemu-trivial] [PATCH 1/5] vnc: pass bool pararmeter for vnc_connect

2013-06-17 Thread li guang
在 2013-06-18二的 06:35 +0400,Michael Tokarev写道: > 11.06.2013 15:50, Michael Tokarev wrote: > > 11.06.2013 09:15, liguang wrote: > >> type last parameter of vnc_connect if bool, > >> so pass 'false' instead of '0' for it. > > > > There's another parameter in here, `skipauth', which should be > > bool

Re: [Qemu-devel] [Qemu-trivial] [PATCH 1/5] vnc: pass bool pararmeter for vnc_connect

2013-06-17 Thread li guang
在 2013-06-11二的 15:50 +0400,Michael Tokarev写道: > 11.06.2013 09:15, liguang wrote: > > type last parameter of vnc_connect if bool, > > so pass 'false' instead of '0' for it. > > There's another parameter in here, `skipauth', which should be > bool in vnc_connect(), and should be bool in vnc_display_

Re: [Qemu-devel] [Qemu-trivial] [PATCH 1/5] vnc: pass bool pararmeter for vnc_connect

2013-06-17 Thread Michael Tokarev
11.06.2013 15:50, Michael Tokarev wrote: > 11.06.2013 09:15, liguang wrote: >> type last parameter of vnc_connect if bool, >> so pass 'false' instead of '0' for it. > > There's another parameter in here, `skipauth', which should be > bool in vnc_connect(), and should be bool in vnc_display_add_cli

Re: [Qemu-devel] [Qemu-trivial] [PATCH 1/5] vnc: pass bool pararmeter for vnc_connect

2013-06-11 Thread Michael Tokarev
11.06.2013 09:15, liguang wrote: > type last parameter of vnc_connect if bool, > so pass 'false' instead of '0' for it. There's another parameter in here, `skipauth', which should be bool in vnc_connect(), and should be bool in vnc_display_add_client() too. Also, there's no big point in splitting