Re: [Qemu-devel] [Qemu devel v2 PATCH] msf2: Remove dead code reported by Coverity

2017-10-22 Thread sundeep subbaraya
Hi Darren, On Wed, Oct 18, 2017 at 4:04 PM, Darren Kenny wrote: > Hi Sundeep, > > > On Wed, Oct 18, 2017 at 10:10:07AM +, sundeep subbaraya wrote: > >> Hi Darren, >> >> On Wed, Oct 18, 2017 at 2:24 PM, Darren Kenny >> wrote: >> >> On Wed, Oct 18, 2017 at 03:40:38AM +, Subbaraya Sundeep

Re: [Qemu-devel] [Qemu devel v2 PATCH] msf2: Remove dead code reported by Coverity

2017-10-18 Thread Darren Kenny
Hi Sundeep, On Wed, Oct 18, 2017 at 10:10:07AM +, sundeep subbaraya wrote: Hi Darren, On Wed, Oct 18, 2017 at 2:24 PM, Darren Kenny wrote: On Wed, Oct 18, 2017 at 03:40:38AM +, Subbaraya Sundeep wrote: Fixed incorrect frame size mask, validated maximum frame size in spi_write and r

Re: [Qemu-devel] [Qemu devel v2 PATCH] msf2: Remove dead code reported by Coverity

2017-10-18 Thread sundeep subbaraya
Hi Darren, On Wed, Oct 18, 2017 at 2:24 PM, Darren Kenny wrote: > On Wed, Oct 18, 2017 at 03:40:38AM +, Subbaraya Sundeep wrote: > >> Fixed incorrect frame size mask, validated maximum frame >> size in spi_write and removed dead code. >> >> Signed-off-by: Subbaraya Sundeep >> --- >> v2: >>

Re: [Qemu-devel] [Qemu devel v2 PATCH] msf2: Remove dead code reported by Coverity

2017-10-18 Thread Darren Kenny
On Wed, Oct 18, 2017 at 03:40:38AM +, Subbaraya Sundeep wrote: Fixed incorrect frame size mask, validated maximum frame size in spi_write and removed dead code. Signed-off-by: Subbaraya Sundeep --- v2: else if -> else in set_fifodepth log guest error when frame size is more

[Qemu-devel] [Qemu devel v2 PATCH] msf2: Remove dead code reported by Coverity

2017-10-17 Thread Subbaraya Sundeep
Fixed incorrect frame size mask, validated maximum frame size in spi_write and removed dead code. Signed-off-by: Subbaraya Sundeep --- v2: else if -> else in set_fifodepth log guest error when frame size is more than 32 hw/ssi/mss-spi.c | 12 1 file changed, 8 inser