Re: [Qemu-devel] [Qemu devel v3 PATCH] msf2: Remove dead code reported by Coverity

2017-10-23 Thread sundeep subbaraya
Hi Fam, On Mon, Oct 23, 2017 at 10:48 AM, Fam Zheng wrote: > On Mon, 10/23 08:59, sundeep subbaraya wrote: > > > Cloning into '/var/tmp/patchew-tester-tmp-egubaaoc/src/dtc'... > > > fatal: Could not read from remote repository. > > > > > > Please make sure you have the correct access rights > >

Re: [Qemu-devel] [Qemu devel v3 PATCH] msf2: Remove dead code reported by Coverity

2017-10-22 Thread Fam Zheng
On Mon, 10/23 08:59, sundeep subbaraya wrote: > > Cloning into '/var/tmp/patchew-tester-tmp-egubaaoc/src/dtc'... > > fatal: Could not read from remote repository. > > > > Please make sure you have the correct access rights > > and the repository exists. > > fatal: clone of 'git://git.qemu-project.o

Re: [Qemu-devel] [Qemu devel v3 PATCH] msf2: Remove dead code reported by Coverity

2017-10-22 Thread sundeep subbaraya
id: 1508678882-4327-1-git-send-email-sundeep.l...@gmail.com > Subject: [Qemu-devel] [Qemu devel v3 PATCH] msf2: Remove dead code > reported by Coverity > > === TEST SCRIPT BEGIN === > #!/bin/bash > set -e > git submodule update --init dtc > # Let docker tests dump environment in

Re: [Qemu-devel] [Qemu devel v3 PATCH] msf2: Remove dead code reported by Coverity

2017-10-22 Thread sundeep subbaraya
Hi Darren, On Mon, Oct 23, 2017 at 12:18 AM, Darren Kenny wrote: > On Sun, Oct 22, 2017 at 06:58:02PM +0530, Subbaraya Sundeep wrote: > >> Fixed incorrect frame size mask, validated maximum frame >> size in spi_write and removed dead code. >> >> Signed-off-by: Subbaraya Sundeep >> --- >> v3: >>

Re: [Qemu-devel] [Qemu devel v3 PATCH] msf2: Remove dead code reported by Coverity

2017-10-22 Thread Darren Kenny
On Sun, Oct 22, 2017 at 06:58:02PM +0530, Subbaraya Sundeep wrote: Fixed incorrect frame size mask, validated maximum frame size in spi_write and removed dead code. Signed-off-by: Subbaraya Sundeep --- v3: Added comment that [31:6] bits are reserved in R_SPI_DFSIZE register and

Re: [Qemu-devel] [Qemu devel v3 PATCH] msf2: Remove dead code reported by Coverity

2017-10-22 Thread no-reply
] msf2: Remove dead code reported by Coverity === TEST SCRIPT BEGIN === #!/bin/bash set -e git submodule update --init dtc # Let docker tests dump environment info export SHOW_ENV=1 export J=8 time make docker-test-quick@centos6 time make docker-test-build@min-glib time make docker-test-mingw@fedora

[Qemu-devel] [Qemu devel v3 PATCH] msf2: Remove dead code reported by Coverity

2017-10-22 Thread Subbaraya Sundeep
Fixed incorrect frame size mask, validated maximum frame size in spi_write and removed dead code. Signed-off-by: Subbaraya Sundeep --- v3: Added comment that [31:6] bits are reserved in R_SPI_DFSIZE register and logged incorrect value too in guest error(suggested by Darren).