Re: [Qemu-devel] [RFC][BROKEN] rbd: Allow configuration of authentication scheme

2018-04-26 Thread Jeff Cody
On Wed, Apr 25, 2018 at 09:50:19AM +0200, Kevin Wolf wrote: > Am 24.04.2018 um 20:26 hat Jeff Cody geschrieben: > > On Fri, Apr 20, 2018 at 04:39:02PM +0200, Markus Armbruster wrote: > > > >> Ways to avoid the troublesome auth-cephx: {}: > > > >> > > > >> (A) Make auth-cephx a bool, rely on the ot

Re: [Qemu-devel] [RFC][BROKEN] rbd: Allow configuration of authentication scheme

2018-04-25 Thread Kevin Wolf
Am 24.04.2018 um 20:26 hat Jeff Cody geschrieben: > On Fri, Apr 20, 2018 at 04:39:02PM +0200, Markus Armbruster wrote: > > >> Ways to avoid the troublesome auth-cephx: {}: > > >> > > >> (A) Make auth-cephx a bool, rely on the other ways to provide the key > > >> > > >> (B) Make auth-cephx a bool

Re: [Qemu-devel] [RFC][BROKEN] rbd: Allow configuration of authentication scheme

2018-04-24 Thread Jeff Cody
On Fri, Apr 20, 2018 at 04:39:02PM +0200, Markus Armbruster wrote: > Kevin Wolf writes: > > > Am 18.04.2018 um 17:06 hat Markus Armbruster geschrieben: > >> Kevin Wolf writes: > >> > >> > The legacy command line syntax supports a "password-secret" option that > >> > allows to pass an authentica

Re: [Qemu-devel] [RFC][BROKEN] rbd: Allow configuration of authentication scheme

2018-04-20 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Fri, Apr 20, 2018 at 04:50:38PM +0200, Markus Armbruster wrote: >> Daniel P. Berrangé writes: >> >> > On Fri, Apr 20, 2018 at 03:34:26PM +0200, Markus Armbruster wrote: >> >> Daniel P. Berrangé writes: >> >> >> >> > Yeah this is a mess - I wish we had never all

Re: [Qemu-devel] [RFC][BROKEN] rbd: Allow configuration of authentication scheme

2018-04-20 Thread Daniel P . Berrangé
On Fri, Apr 20, 2018 at 04:50:38PM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > On Fri, Apr 20, 2018 at 03:34:26PM +0200, Markus Armbruster wrote: > >> Daniel P. Berrangé writes: > >> > >> > Yeah this is a mess - I wish we had never allowed users to pass a config > >> > fi

Re: [Qemu-devel] [RFC][BROKEN] rbd: Allow configuration of authentication scheme

2018-04-20 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Fri, Apr 20, 2018 at 03:34:26PM +0200, Markus Armbruster wrote: >> Daniel P. Berrangé writes: >> >> > Yeah this is a mess - I wish we had never allowed users to pass a config >> > file, and had used /dev/null all the time. Unfortunately changing either >> > of th

Re: [Qemu-devel] [RFC][BROKEN] rbd: Allow configuration of authentication scheme

2018-04-20 Thread Markus Armbruster
Kevin Wolf writes: > Am 18.04.2018 um 17:06 hat Markus Armbruster geschrieben: >> Kevin Wolf writes: >> >> > The legacy command line syntax supports a "password-secret" option that >> > allows to pass an authentication key to Ceph. This was not supported in >> > QMP so far. >> >> We tried duri

Re: [Qemu-devel] [RFC][BROKEN] rbd: Allow configuration of authentication scheme

2018-04-20 Thread Daniel P . Berrangé
On Fri, Apr 20, 2018 at 03:34:26PM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > On Wed, Apr 18, 2018 at 06:52:08PM +0200, Kevin Wolf wrote: > >> Am 18.04.2018 um 18:34 hat Daniel P. Berrangé geschrieben: > >> > On Wed, Apr 18, 2018 at 06:28:23PM +0200, Kevin Wolf wrote: > >>

Re: [Qemu-devel] [RFC][BROKEN] rbd: Allow configuration of authentication scheme

2018-04-20 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Wed, Apr 18, 2018 at 06:52:08PM +0200, Kevin Wolf wrote: >> Am 18.04.2018 um 18:34 hat Daniel P. Berrangé geschrieben: >> > On Wed, Apr 18, 2018 at 06:28:23PM +0200, Kevin Wolf wrote: >> > > Am 18.04.2018 um 17:06 hat Markus Armbruster geschrieben: >> > >> > > >

Re: [Qemu-devel] [RFC][BROKEN] rbd: Allow configuration of authentication scheme

2018-04-18 Thread Daniel P . Berrangé
On Wed, Apr 18, 2018 at 06:52:08PM +0200, Kevin Wolf wrote: > Am 18.04.2018 um 18:34 hat Daniel P. Berrangé geschrieben: > > On Wed, Apr 18, 2018 at 06:28:23PM +0200, Kevin Wolf wrote: > > > Am 18.04.2018 um 17:06 hat Markus Armbruster geschrieben: > > > > > > Note that users can still configu

Re: [Qemu-devel] [RFC][BROKEN] rbd: Allow configuration of authentication scheme

2018-04-18 Thread Kevin Wolf
Am 18.04.2018 um 18:34 hat Daniel P. Berrangé geschrieben: > On Wed, Apr 18, 2018 at 06:28:23PM +0200, Kevin Wolf wrote: > > Am 18.04.2018 um 17:06 hat Markus Armbruster geschrieben: > > > > Note that users can still configure authentication methods with a > > > configuration file. They p

Re: [Qemu-devel] [RFC][BROKEN] rbd: Allow configuration of authentication scheme

2018-04-18 Thread Daniel P . Berrangé
On Wed, Apr 18, 2018 at 06:28:23PM +0200, Kevin Wolf wrote: > Am 18.04.2018 um 17:06 hat Markus Armbruster geschrieben: > > Note that users can still configure authentication methods with a > > configuration file. They probably do that anyway if they use Ceph > > outside QEMU as well.

Re: [Qemu-devel] [RFC][BROKEN] rbd: Allow configuration of authentication scheme

2018-04-18 Thread Kevin Wolf
Am 18.04.2018 um 17:06 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > The legacy command line syntax supports a "password-secret" option that > > allows to pass an authentication key to Ceph. This was not supported in > > QMP so far. > > We tried during development of v2.9.0 (comm

Re: [Qemu-devel] [RFC][BROKEN] rbd: Allow configuration of authentication scheme

2018-04-18 Thread Markus Armbruster
Kevin Wolf writes: > The legacy command line syntax supports a "password-secret" option that > allows to pass an authentication key to Ceph. This was not supported in > QMP so far. We tried during development of v2.9.0 (commit 0a55679b4a5), but reverted before the release: commit 46fcc16128

Re: [Qemu-devel] [RFC][BROKEN] rbd: Allow configuration of authentication scheme

2018-04-18 Thread Kevin Wolf
Am 18.04.2018 um 16:16 hat Eric Blake geschrieben: > On 04/18/2018 08:50 AM, Kevin Wolf wrote: > > >>> @@ -3195,6 +3215,8 @@ > >>> '*conf': 'str', > >>> '*snapshot': 'str', > >>> '*user': 'str', > >>> +'*auth-none': 'bool', > >>> +'*au

Re: [Qemu-devel] [RFC][BROKEN] rbd: Allow configuration of authentication scheme

2018-04-18 Thread Eric Blake
On 04/18/2018 08:50 AM, Kevin Wolf wrote: >>> @@ -3195,6 +3215,8 @@ >>> '*conf': 'str', >>> '*snapshot': 'str', >>> '*user': 'str', >>> +'*auth-none': 'bool', >>> +'*auth-cephx': 'RbdAuthCephx', >>> '*server': ['InetSocket

Re: [Qemu-devel] [RFC][BROKEN] rbd: Allow configuration of authentication scheme

2018-04-18 Thread Kevin Wolf
Am 18.04.2018 um 15:26 hat Eric Blake geschrieben: > On 04/05/2018 12:06 PM, Kevin Wolf wrote: > > The legacy command line syntax supports a "password-secret" option that > > allows to pass an authentication key to Ceph. This was not supported in > > QMP so far. > > > > This patch introduces authe

Re: [Qemu-devel] [RFC][BROKEN] rbd: Allow configuration of authentication scheme

2018-04-18 Thread Kevin Wolf
Am 18.04.2018 um 15:21 hat Eric Blake geschrieben: > On 04/06/2018 03:04 AM, Kevin Wolf wrote: > > Am 05.04.2018 um 19:06 hat Kevin Wolf geschrieben: > >> The legacy command line syntax supports a "password-secret" option that > >> allows to pass an authentication key to Ceph. This was not supporte

Re: [Qemu-devel] [RFC][BROKEN] rbd: Allow configuration of authentication scheme

2018-04-18 Thread Eric Blake
On 04/05/2018 12:06 PM, Kevin Wolf wrote: > The legacy command line syntax supports a "password-secret" option that > allows to pass an authentication key to Ceph. This was not supported in > QMP so far. > > This patch introduces authentication options in the QAPI schema, makes > them do the corre

Re: [Qemu-devel] [RFC][BROKEN] rbd: Allow configuration of authentication scheme

2018-04-18 Thread Eric Blake
On 04/06/2018 03:04 AM, Kevin Wolf wrote: > Am 05.04.2018 um 19:06 hat Kevin Wolf geschrieben: >> The legacy command line syntax supports a "password-secret" option that >> allows to pass an authentication key to Ceph. This was not supported in >> QMP so far. >> >> This patch introduces authenticat

Re: [Qemu-devel] [RFC][BROKEN] rbd: Allow configuration of authentication scheme

2018-04-06 Thread Kevin Wolf
Am 05.04.2018 um 19:06 hat Kevin Wolf geschrieben: > The legacy command line syntax supports a "password-secret" option that > allows to pass an authentication key to Ceph. This was not supported in > QMP so far. > > This patch introduces authentication options in the QAPI schema, makes > them do

[Qemu-devel] [RFC][BROKEN] rbd: Allow configuration of authentication scheme

2018-04-05 Thread Kevin Wolf
The legacy command line syntax supports a "password-secret" option that allows to pass an authentication key to Ceph. This was not supported in QMP so far. This patch introduces authentication options in the QAPI schema, makes them do the corresponding rados_conf_set() calls and adds compatibility