Re: [Qemu-devel] [RFC][PATCH] qemu_opt_get_bool_helper: back finding desc by name just if !opt->desc

2015-01-06 Thread Chen, Tiejun
On 2015/1/6 22:56, Stefan Hajnoczi wrote: On Tue, Jan 06, 2015 at 10:39:13AM +0800, Chen, Tiejun wrote: On 2015/1/6 9:21, Chen, Tiejun wrote: On 2015/1/6 1:13, Eric Blake wrote: On 01/04/2015 10:35 PM, Tiejun Chen wrote: After one commit 49d2e648e808, "machine: remove qemu_machine_opts global

Re: [Qemu-devel] [RFC][PATCH] qemu_opt_get_bool_helper: back finding desc by name just if !opt->desc

2015-01-06 Thread Marcel Apfelbaum
On 01/06/2015 04:56 PM, Stefan Hajnoczi wrote: On Tue, Jan 06, 2015 at 10:39:13AM +0800, Chen, Tiejun wrote: On 2015/1/6 9:21, Chen, Tiejun wrote: On 2015/1/6 1:13, Eric Blake wrote: On 01/04/2015 10:35 PM, Tiejun Chen wrote: After one commit 49d2e648e808, "machine: remove qemu_machine_opts g

Re: [Qemu-devel] [RFC][PATCH] qemu_opt_get_bool_helper: back finding desc by name just if !opt->desc

2015-01-06 Thread Stefan Hajnoczi
On Tue, Jan 06, 2015 at 10:39:13AM +0800, Chen, Tiejun wrote: > On 2015/1/6 9:21, Chen, Tiejun wrote: > >On 2015/1/6 1:13, Eric Blake wrote: > >>On 01/04/2015 10:35 PM, Tiejun Chen wrote: > >>>After one commit 49d2e648e808, "machine: remove qemu_machine_opts > >>>global list", is introduced, QEMU d

Re: [Qemu-devel] [RFC][PATCH] qemu_opt_get_bool_helper: back finding desc by name just if !opt->desc

2015-01-05 Thread Chen, Tiejun
On 2015/1/6 9:21, Chen, Tiejun wrote: On 2015/1/6 1:13, Eric Blake wrote: On 01/04/2015 10:35 PM, Tiejun Chen wrote: After one commit 49d2e648e808, "machine: remove qemu_machine_opts global list", is introduced, QEMU doesn't keep a global list of options but set desc lately. Then we can see the

Re: [Qemu-devel] [RFC][PATCH] qemu_opt_get_bool_helper: back finding desc by name just if !opt->desc

2015-01-05 Thread Chen, Tiejun
On 2015/1/6 1:13, Eric Blake wrote: On 01/04/2015 10:35 PM, Tiejun Chen wrote: After one commit 49d2e648e808, "machine: remove qemu_machine_opts global list", is introduced, QEMU doesn't keep a global list of options but set desc lately. Then we can see the following, $ x86_64-softmmu/qemu-syst

Re: [Qemu-devel] [RFC][PATCH] qemu_opt_get_bool_helper: back finding desc by name just if !opt->desc

2015-01-05 Thread Eric Blake
On 01/04/2015 10:35 PM, Tiejun Chen wrote: > After one commit 49d2e648e808, "machine: remove qemu_machine_opts > global list", is introduced, QEMU doesn't keep a global list of > options but set desc lately. Then we can see the following, > > $ x86_64-softmmu/qemu-system-x86_64 -usb > qemu-system-

[Qemu-devel] [RFC][PATCH] qemu_opt_get_bool_helper: back finding desc by name just if !opt->desc

2015-01-04 Thread Tiejun Chen
After one commit 49d2e648e808, "machine: remove qemu_machine_opts global list", is introduced, QEMU doesn't keep a global list of options but set desc lately. Then we can see the following, $ x86_64-softmmu/qemu-system-x86_64 -usb qemu-system-x86_64: util/qemu-option.c:387: qemu_opt_get_bool_helpe