Re: [Qemu-devel] [RFC][PATCH 06/45] msix: Prevent bogus mask updates on MMIO accesses

2011-10-17 Thread Jan Kiszka
On 2011-10-17 14:50, Michael S. Tsirkin wrote: > On Mon, Oct 17, 2011 at 02:07:10PM +0200, Jan Kiszka wrote: >> On 2011-10-17 13:57, Michael S. Tsirkin wrote: >>> On Mon, Oct 17, 2011 at 01:23:46PM +0200, Jan Kiszka wrote: On 2011-10-17 13:10, Michael S. Tsirkin wrote: > On Mon, Oct 17, 20

Re: [Qemu-devel] [RFC][PATCH 06/45] msix: Prevent bogus mask updates on MMIO accesses

2011-10-17 Thread Michael S. Tsirkin
On Mon, Oct 17, 2011 at 09:11:29PM +0200, Jan Kiszka wrote: > On 2011-10-17 14:50, Michael S. Tsirkin wrote: > > On Mon, Oct 17, 2011 at 02:07:10PM +0200, Jan Kiszka wrote: > >> On 2011-10-17 13:57, Michael S. Tsirkin wrote: > >>> On Mon, Oct 17, 2011 at 01:23:46PM +0200, Jan Kiszka wrote: > O

Re: [Qemu-devel] [RFC][PATCH 06/45] msix: Prevent bogus mask updates on MMIO accesses

2011-10-17 Thread Michael S. Tsirkin
On Mon, Oct 17, 2011 at 02:07:10PM +0200, Jan Kiszka wrote: > On 2011-10-17 13:57, Michael S. Tsirkin wrote: > > On Mon, Oct 17, 2011 at 01:23:46PM +0200, Jan Kiszka wrote: > >> On 2011-10-17 13:10, Michael S. Tsirkin wrote: > >>> On Mon, Oct 17, 2011 at 11:27:40AM +0200, Jan Kiszka wrote: > O

Re: [Qemu-devel] [RFC][PATCH 06/45] msix: Prevent bogus mask updates on MMIO accesses

2011-10-17 Thread Jan Kiszka
On 2011-10-17 13:57, Michael S. Tsirkin wrote: > On Mon, Oct 17, 2011 at 01:23:46PM +0200, Jan Kiszka wrote: >> On 2011-10-17 13:10, Michael S. Tsirkin wrote: >>> On Mon, Oct 17, 2011 at 11:27:40AM +0200, Jan Kiszka wrote: Only accesses to the MSI-X table must trigger a call to msix_handl

Re: [Qemu-devel] [RFC][PATCH 06/45] msix: Prevent bogus mask updates on MMIO accesses

2011-10-17 Thread Michael S. Tsirkin
On Mon, Oct 17, 2011 at 01:23:46PM +0200, Jan Kiszka wrote: > On 2011-10-17 13:10, Michael S. Tsirkin wrote: > > On Mon, Oct 17, 2011 at 11:27:40AM +0200, Jan Kiszka wrote: > >> Only accesses to the MSI-X table must trigger a call to > >> msix_handle_mask_update or a notifier invocation. > >> > >>

Re: [Qemu-devel] [RFC][PATCH 06/45] msix: Prevent bogus mask updates on MMIO accesses

2011-10-17 Thread Jan Kiszka
On 2011-10-17 13:10, Michael S. Tsirkin wrote: > On Mon, Oct 17, 2011 at 11:27:40AM +0200, Jan Kiszka wrote: >> Only accesses to the MSI-X table must trigger a call to >> msix_handle_mask_update or a notifier invocation. >> >> Signed-off-by: Jan Kiszka > > Why would msix_mmio_write be called on a

Re: [Qemu-devel] [RFC][PATCH 06/45] msix: Prevent bogus mask updates on MMIO accesses

2011-10-17 Thread Michael S. Tsirkin
On Mon, Oct 17, 2011 at 11:27:40AM +0200, Jan Kiszka wrote: > Only accesses to the MSI-X table must trigger a call to > msix_handle_mask_update or a notifier invocation. > > Signed-off-by: Jan Kiszka Why would msix_mmio_write be called on an access outside the table? > --- > hw/msix.c | 16 +

[Qemu-devel] [RFC][PATCH 06/45] msix: Prevent bogus mask updates on MMIO accesses

2011-10-17 Thread Jan Kiszka
Only accesses to the MSI-X table must trigger a call to msix_handle_mask_update or a notifier invocation. Signed-off-by: Jan Kiszka --- hw/msix.c | 16 ++-- 1 files changed, 10 insertions(+), 6 deletions(-) diff --git a/hw/msix.c b/hw/msix.c index 2c4de21..33cb716 100644 --- a/hw/