Re: [Qemu-devel] [RFC][PATCH 11/14 v9] introduce a new monitor command 'dump' to dump guest's memory

2012-03-19 Thread Wen Congyang
At 03/19/2012 10:28 AM, Wen Congyang Wrote: At 03/15/2012 01:18 AM, Luiz Capitulino Wrote: On Wed, 14 Mar 2012 10:11:35 +0800 Wen Congyang we...@cn.fujitsu.com wrote: The command's usage: dump [-p] file file should be start with file:(the file's path) or fd:(the fd's name). Note: 1.

Re: [Qemu-devel] [RFC][PATCH 11/14 v9] introduce a new monitor command 'dump' to dump guest's memory

2012-03-19 Thread Luiz Capitulino
On Mon, 19 Mar 2012 10:28:17 +0800 Wen Congyang we...@cn.fujitsu.com wrote: 'dump' is too generic, please call this dump-guest-memory-vmcore or something more descriptive. Hmm, dump-guest-memory-vmcore is too long. What about dump-guest-memory or dump-memory? dump-guest-memory is

Re: [Qemu-devel] [RFC][PATCH 11/14 v9] introduce a new monitor command 'dump' to dump guest's memory

2012-03-18 Thread Wen Congyang
At 03/15/2012 01:18 AM, Luiz Capitulino Wrote: On Wed, 14 Mar 2012 10:11:35 +0800 Wen Congyang we...@cn.fujitsu.com wrote: The command's usage: dump [-p] file file should be start with file:(the file's path) or fd:(the fd's name). Note: 1. If you want to use gdb to analyse the core,

Re: [Qemu-devel] [RFC][PATCH 11/14 v9] introduce a new monitor command 'dump' to dump guest's memory

2012-03-16 Thread Wen Congyang
At 03/16/2012 11:23 AM, HATAYAMA Daisuke Wrote: From: Wen Congyang we...@cn.fujitsu.com Subject: [RFC][PATCH 11/14 v9] introduce a new monitor command 'dump' to dump guest's memory Date: Wed, 14 Mar 2012 10:11:35 +0800 +/* + * QEMU dump + * + * Copyright Fujitsu, Corp. 2011 + * Now

Re: [Qemu-devel] [RFC][PATCH 11/14 v9] introduce a new monitor command 'dump' to dump guest's memory

2012-03-16 Thread Wen Congyang
At 03/15/2012 01:18 AM, Luiz Capitulino Wrote: On Wed, 14 Mar 2012 10:11:35 +0800 Wen Congyang we...@cn.fujitsu.com wrote: The command's usage: dump [-p] file file should be start with file:(the file's path) or fd:(the fd's name). Note: 1. If you want to use gdb to analyse the core,

Re: [Qemu-devel] [RFC][PATCH 11/14 v9] introduce a new monitor command 'dump' to dump guest's memory

2012-03-15 Thread Luiz Capitulino
On Wed, 14 Mar 2012 14:18:47 -0300 Luiz Capitulino lcapitul...@redhat.com wrote: +ret = write(fd, buf, size); +if (ret != size) { +return -1; +} I think you should use send_all() instead of plain write(). Missed the fact that we actually have qemu_write_full().

Re: [Qemu-devel] [RFC][PATCH 11/14 v9] introduce a new monitor command 'dump' to dump guest's memory

2012-03-15 Thread HATAYAMA Daisuke
From: Wen Congyang we...@cn.fujitsu.com Subject: [RFC][PATCH 11/14 v9] introduce a new monitor command 'dump' to dump guest's memory Date: Wed, 14 Mar 2012 10:11:35 +0800 +/* + * QEMU dump + * + * Copyright Fujitsu, Corp. 2011 + * Now 2012. +/* + * calculate phdr_num + * +

Re: [Qemu-devel] [RFC][PATCH 11/14 v9] introduce a new monitor command 'dump' to dump guest's memory

2012-03-14 Thread Wen Congyang
At 03/15/2012 01:18 AM, Luiz Capitulino Wrote: On Wed, 14 Mar 2012 10:11:35 +0800 Wen Congyang we...@cn.fujitsu.com wrote: cut You just dropped a few asynchronous bits and resent this as a synchronous command, letting all the asynchronous infrastructure in. This is bad, as the command

Re: [Qemu-devel] [RFC][PATCH 11/14 v9] introduce a new monitor command 'dump' to dump guest's memory

2012-03-14 Thread Luiz Capitulino
On Wed, 14 Mar 2012 10:11:35 +0800 Wen Congyang we...@cn.fujitsu.com wrote: The command's usage: dump [-p] file file should be start with file:(the file's path) or fd:(the fd's name). Note: 1. If you want to use gdb to analyse the core, please specify -p option. 2. This command

[Qemu-devel] [RFC][PATCH 11/14 v9] introduce a new monitor command 'dump' to dump guest's memory

2012-03-13 Thread Wen Congyang
The command's usage: dump [-p] file file should be start with file:(the file's path) or fd:(the fd's name). Note: 1. If you want to use gdb to analyse the core, please specify -p option. 2. This command doesn't support the fd that is is associated with a pipe, socket, or FIFO(lseek