Re: [Qemu-devel] [RFC][PATCH 23/45] qemu-kvm: Rework MSI-X mask notifier to generic MSI config notifiers

2011-10-18 Thread Jan Kiszka
On 2011-10-18 15:46, Michael S. Tsirkin wrote: To have common types, I would prefer to stay with vector config notifiers as name then. Jan >>> >>> So we pass in nonsense values and ask all users to know about MSIX rules. >>> Ugh. >>> >>> I do realize msi might change the ve

Re: [Qemu-devel] [RFC][PATCH 23/45] qemu-kvm: Rework MSI-X mask notifier to generic MSI config notifiers

2011-10-18 Thread Michael S. Tsirkin
On Mon, Oct 17, 2011 at 09:08:58PM +0200, Jan Kiszka wrote: > On 2011-10-17 14:39, Michael S. Tsirkin wrote: > > On Mon, Oct 17, 2011 at 01:45:04PM +0200, Jan Kiszka wrote: > >> On 2011-10-17 13:40, Michael S. Tsirkin wrote: > >>> On Mon, Oct 17, 2011 at 11:27:57AM +0200, Jan Kiszka wrote: > M

Re: [Qemu-devel] [RFC][PATCH 23/45] qemu-kvm: Rework MSI-X mask notifier to generic MSI config notifiers

2011-10-17 Thread Jan Kiszka
On 2011-10-17 14:39, Michael S. Tsirkin wrote: > On Mon, Oct 17, 2011 at 01:45:04PM +0200, Jan Kiszka wrote: >> On 2011-10-17 13:40, Michael S. Tsirkin wrote: >>> On Mon, Oct 17, 2011 at 11:27:57AM +0200, Jan Kiszka wrote: MSI config notifiers are supposed to be triggered on every relevant >>>

Re: [Qemu-devel] [RFC][PATCH 23/45] qemu-kvm: Rework MSI-X mask notifier to generic MSI config notifiers

2011-10-17 Thread Michael S. Tsirkin
On Mon, Oct 17, 2011 at 01:45:04PM +0200, Jan Kiszka wrote: > On 2011-10-17 13:40, Michael S. Tsirkin wrote: > > On Mon, Oct 17, 2011 at 11:27:57AM +0200, Jan Kiszka wrote: > >> MSI config notifiers are supposed to be triggered on every relevant > >> configuration change of MSI vectors or if MSI is

Re: [Qemu-devel] [RFC][PATCH 23/45] qemu-kvm: Rework MSI-X mask notifier to generic MSI config notifiers

2011-10-17 Thread Jan Kiszka
On 2011-10-17 13:40, Michael S. Tsirkin wrote: > On Mon, Oct 17, 2011 at 11:27:57AM +0200, Jan Kiszka wrote: >> MSI config notifiers are supposed to be triggered on every relevant >> configuration change of MSI vectors or if MSI is enabled/disabled. >> >> Two notifiers are established, one for vect

Re: [Qemu-devel] [RFC][PATCH 23/45] qemu-kvm: Rework MSI-X mask notifier to generic MSI config notifiers

2011-10-17 Thread Michael S. Tsirkin
On Mon, Oct 17, 2011 at 11:27:57AM +0200, Jan Kiszka wrote: > MSI config notifiers are supposed to be triggered on every relevant > configuration change of MSI vectors or if MSI is enabled/disabled. > > Two notifiers are established, one for vector changes and one for general > enabling. The forme

[Qemu-devel] [RFC][PATCH 23/45] qemu-kvm: Rework MSI-X mask notifier to generic MSI config notifiers

2011-10-17 Thread Jan Kiszka
MSI config notifiers are supposed to be triggered on every relevant configuration change of MSI vectors or if MSI is enabled/disabled. Two notifiers are established, one for vector changes and one for general enabling. The former notifier additionally passes the currently active MSI message. This