Re: [Qemu-devel] [RFC][PATCH v2 1/4] tcg: add declarations and templates of extended MMU helpers

2012-07-06 Thread Wei-Ren Chen
> > Also, please line wrap your commit messages. > I didn't know the line wrap rule of commit message. Is the rule included > in checkpatch.pl? Let me check it. I guess it's 80 char length rule? Regards, chenwj -- Wei-Ren Chen (陳韋任) Computer Systems Lab, Institute of Information Science, Aca

Re: [Qemu-devel] [RFC][PATCH v2 1/4] tcg: add declarations and templates of extended MMU helpers

2012-07-06 Thread Yeongkyoon Lee
Add declarations and templates of extended MMU helpers which can take return address argument to what helper functions return. These extended helper functions are called only by generated code. It's not entirely clear from this description what the return address argument actually is. My commit

Re: [Qemu-devel] [RFC][PATCH v2 1/4] tcg: add declarations and templates of extended MMU helpers

2012-07-05 Thread Peter Maydell
On 5 July 2012 14:23, Yeongkyoon Lee wrote: > Add declarations and templates of extended MMU helpers which can take return > address argument to what helper functions return. These extended helper > functions are called only by generated code. It's not entirely clear from this description what

[Qemu-devel] [RFC][PATCH v2 1/4] tcg: add declarations and templates of extended MMU helpers

2012-07-05 Thread Yeongkyoon Lee
Add declarations and templates of extended MMU helpers which can take return address argument to what helper functions return. These extended helper functions are called only by generated code. Signed-off-by: Yeongkyoon Lee --- softmmu_defs.h | 13 + softmmu_template.h | 51