Re: [Qemu-devel] [RFC] Allow AMD IOMMU to have both SysBusDevice and PCIDevice properties.

2016-06-11 Thread David Kiarie
On Thu, Jun 9, 2016 at 4:23 PM, Marcel Apfelbaum wrote: > On 06/07/2016 10:12 PM, Eduardo Habkost wrote: >> >> Hi, >> > > [...] > >> [...] >>> >>> diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c >>> index 04aae89..431eaed 100644 >>> --- a/hw/i386/pc_q35.c >>> +++ b/hw/i386/pc_q35.c >>> @@ -281,6

Re: [Qemu-devel] [RFC] Allow AMD IOMMU to have both SysBusDevice and PCIDevice properties.

2016-06-09 Thread Marcel Apfelbaum
On 06/07/2016 10:12 PM, Eduardo Habkost wrote: Hi, [...] [...] diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c index 04aae89..431eaed 100644 --- a/hw/i386/pc_q35.c +++ b/hw/i386/pc_q35.c @@ -281,6 +281,7 @@ static void pc_q35_machine_options(MachineClass *m) m->default_machine_opts =

Re: [Qemu-devel] [RFC] Allow AMD IOMMU to have both SysBusDevice and PCIDevice properties.

2016-06-07 Thread Peter Xu
On Tue, Jun 07, 2016 at 10:32:34PM +0300, David Kiarie wrote: > On Tue, Jun 7, 2016 at 10:12 PM, Eduardo Habkost wrote: > > Hi, > > Hello, > > > > > I didn't review the amd_iommu.c code, but there seems to be some > > unrelated changes in the patch: > > Thanks for looking at this but I actually

Re: [Qemu-devel] [RFC] Allow AMD IOMMU to have both SysBusDevice and PCIDevice properties.

2016-06-07 Thread David Kiarie
On Tue, Jun 7, 2016 at 10:12 PM, Eduardo Habkost wrote: > Hi, Hello, > > I didn't review the amd_iommu.c code, but there seems to be some > unrelated changes in the patch: Thanks for looking at this but I actually wanted someone to look at the amd_iommu.c. I mentioned in annotation that there a

Re: [Qemu-devel] [RFC] Allow AMD IOMMU to have both SysBusDevice and PCIDevice properties.

2016-06-07 Thread Eduardo Habkost
Hi, I didn't review the amd_iommu.c code, but there seems to be some unrelated changes in the patch: On Sun, Jun 05, 2016 at 07:54:33PM +0300, David Kiarie wrote: > Signed-off-by: David Kiarie > --- > hw/acpi/aml-build.c |2 +- > hw/i386/amd_iommu.c | 1471 > +++

[Qemu-devel] [RFC] Allow AMD IOMMU to have both SysBusDevice and PCIDevice properties.

2016-06-05 Thread David Kiarie
Signed-off-by: David Kiarie --- hw/acpi/aml-build.c |2 +- hw/i386/amd_iommu.c | 1471 +++ hw/i386/amd_iommu.h | 348 ++ hw/i386/kvm/pci-assign.c|2 +- hw/i386/pc_q35.c|1 + include/hw/acpi/acpi-d