On 2013/5/30 20:48, Stefan Hajnoczi wrote:
hain 1.qcow2' don't crash.
qemu-img info --backing-chain detects cycles and returns an error, see
the hash table in collect_image_info_list().
We should protect bdrv_open() too.
Okay, will send a patch.
Stefan
On Thu, May 30, 2013 at 06:12:00AM -0600, Eric Blake wrote:
> On 05/30/2013 04:14 AM, Dongxu Wang wrote:
> > Hi,
> >
> > Now block layer does not check whether backing_file chain can be a
> > circle, do you think it is necessary to do a check?
> >
> > For example, 1.qcow2's backing_file is 2.qco
On 05/30/2013 04:14 AM, Dongxu Wang wrote:
> Hi,
>
> Now block layer does not check whether backing_file chain can be a
> circle, do you think it is necessary to do a check?
>
> For example, 1.qcow2's backing_file is 2.qcow2 and 2.qcow2's
> backing_file is 1.qcow2, then any IO operation will be
Hi,
Now block layer does not check whether backing_file chain can be a
circle, do you think it is necessary to do a check?
For example, 1.qcow2's backing_file is 2.qcow2 and 2.qcow2's
backing_file is 1.qcow2, then any IO operation will be a fault.
If necessary, I will post a patch to fix.