Re: [Qemu-devel] [RFC] spice-core: allow setting properties from QMP

2019-06-21 Thread Kevin Pouget
On Fri, Jun 21, 2019 at 9:16 AM Frediano Ziglio wrote: > > > > > Hello Eric, > > > > > A new command may be okay, however, > > > > thanks, I've fix the typos and updated the patch to use an Enum, which > > indeed makes more sense. > > > > I've also updated "spice-query" command to provide the curr

Re: [Qemu-devel] [RFC] spice-core: allow setting properties from QMP

2019-06-21 Thread Frediano Ziglio
> > Hello Eric, > > > A new command may be okay, however, > > thanks, I've fix the typos and updated the patch to use an Enum, which > indeed makes more sense. > > I've also updated "spice-query" command to provide the current value > of the "video-codec" property, > but it made me wonder if I

Re: [Qemu-devel] [RFC] spice-core: allow setting properties from QMP

2019-06-20 Thread Kevin Pouget
Hello Eric, > A new command may be okay, however, thanks, I've fix the typos and updated the patch to use an Enum, which indeed makes more sense. I've also updated "spice-query" command to provide the current value of the "video-codec" property, but it made me wonder if I should improve this QMP

Re: [Qemu-devel] [RFC] spice-core: allow setting properties from QMP

2019-06-19 Thread Eric Blake
On 6/19/19 7:30 AM, Kevin Pouget wrote: > Hello, > > we're investigating the possibility to set some spice properties at > runtime, through the QMP interface, but we're not sure what's the best > way to proceed. > I've prepared the patch below, that adds a new QMP > command, but is there another w

Re: [Qemu-devel] [RFC] spice-core: allow setting properties from QMP

2019-06-19 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190619123042.4822-1-kpou...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [RFC] spice-core: allow setting properties from QMP Type: series Message-id

[Qemu-devel] [RFC] spice-core: allow setting properties from QMP

2019-06-19 Thread Kevin Pouget
Hello, we're investigating the possibility to set some spice properties at runtime, through the QMP interface, but we're not sure what's the best way to proceed. I've prepared the patch below, that adds a new QMP command, but is there another way like with a QOM object, that could reuse an existin