Anthony Liguori wrote:
Jamie Lokier wrote:
Adam Litke wrote:
+s-stats.pswapin = has_feature(dev,
VIRTIO_BALLOON_F_RPT_SWAP_OUT) ?
+ dev-stats.pswapin : -1;
(etc.)
Why not simply have the guest fill in the unused fields with -1,
Changes since V1:
- In the monitor, print all stats on one line with less abbreviated names
- Coding style changes
When using ballooning to manage overcommitted memory on a host, a system for
guests to communicate their memory usage to the host can provide information
that will minimize the
Adam Litke wrote:
+s-stats.pswapin = has_feature(dev, VIRTIO_BALLOON_F_RPT_SWAP_OUT) ?
+ dev-stats.pswapin : -1;
(etc.)
Why not simply have the guest fill in the unused fields with -1, and
say that's how no meaningful value is represented in the
Adam Litke wrote:
+static inline void print_stat(Monitor *mon, uint32_t val, const char *label)
+{
+if (val != -1) {
+monitor_printf(mon, ,%s=%u, label, val);
+}
+}
+
static void do_info_balloon(Monitor *mon)
{
-ram_addr_t actual;
+QEMUBalloonState s;
+int
On Mon, 2009-11-09 at 19:00 +, Jamie Lokier wrote:
Adam Litke wrote:
+s-stats.pswapin = has_feature(dev, VIRTIO_BALLOON_F_RPT_SWAP_OUT)
?
+ dev-stats.pswapin : -1;
(etc.)
Why not simply have the guest fill in the unused fields with
On Mon, 2009-11-09 at 19:01 +, Jamie Lokier wrote:
These days, would it make more sense to emit a QJSON object?
In this case the JSON object is quite human readable too.
I'm not very particular on the output format since it's main consumer is
likely another program. Is XML output via the
Jamie Lokier wrote:
Adam Litke wrote:
+s-stats.pswapin = has_feature(dev, VIRTIO_BALLOON_F_RPT_SWAP_OUT) ?
+ dev-stats.pswapin : -1;
(etc.)
Why not simply have the guest fill in the unused fields with -1, and
say that's how no meaningful
