Re: [Qemu-devel] [RFC] virtio-mmio: implement modern (v2) personality (virtio-1)

2019-08-02 Thread Laszlo Ersek
On 08/02/19 11:20, Peter Maydell wrote: > On Fri, 2 Aug 2019 at 01:26, Laszlo Ersek wrote: >> But it's extra work, not entirely risk-free (regressions), and I can't >> tell if someone out there still uses virtio-mmio (despite me thinking >> that would be unreasonable). I wouldn't like to see more

Re: [Qemu-devel] [RFC] virtio-mmio: implement modern (v2) personality (virtio-1)

2019-08-02 Thread Paolo Bonzini
On 01/08/19 21:45, Michael S. Tsirkin wrote: >>> OVMF is a heavy-weight guest firmware, which I see entirely out of scope >>> for "micro VMs". And so virtio-mmio/1.0 would seem like a needless & >>> unwelcome complication, from the OVMF maintainership perspective. >> But given that, why not rip

Re: [Qemu-devel] [RFC] virtio-mmio: implement modern (v2) personality (virtio-1)

2019-08-02 Thread Peter Maydell
On Fri, 2 Aug 2019 at 01:26, Laszlo Ersek wrote: > But it's extra work, not entirely risk-free (regressions), and I can't > tell if someone out there still uses virtio-mmio (despite me thinking > that would be unreasonable). I wouldn't like to see more work sunk into > it either way :) The main

Re: [Qemu-devel] [RFC] virtio-mmio: implement modern (v2) personality (virtio-1)

2019-08-01 Thread Laszlo Ersek
On 08/01/19 01:58, Paolo Bonzini wrote: > On 30/07/19 18:06, Laszlo Ersek wrote: >> On 07/29/19 14:57, Sergio Lopez wrote: >>> Implement the modern (v2) personality, according to the VirtIO 1.0 >>> specification. >>> >>> Support for v2 among guests is not as widespread as it'd be >>> desirable.

Re: [Qemu-devel] [RFC] virtio-mmio: implement modern (v2) personality (virtio-1)

2019-08-01 Thread Michael S. Tsirkin
On Thu, Aug 01, 2019 at 01:58:35AM +0200, Paolo Bonzini wrote: > On 30/07/19 18:06, Laszlo Ersek wrote: > > On 07/29/19 14:57, Sergio Lopez wrote: > >> Implement the modern (v2) personality, according to the VirtIO 1.0 > >> specification. > >> > >> Support for v2 among guests is not as widespread

Re: [Qemu-devel] [RFC] virtio-mmio: implement modern (v2) personality (virtio-1)

2019-08-01 Thread Michael S. Tsirkin
On Wed, Jul 31, 2019 at 01:02:13PM +0200, Sergio Lopez wrote: > > Andrea Bolognani writes: > > > On Mon, 2019-07-29 at 14:57 +0200, Sergio Lopez wrote: > > [...] > >> /* virtio-mmio device */ > >> > >> static Property virtio_mmio_properties[] = { > >>

Re: [Qemu-devel] [RFC] virtio-mmio: implement modern (v2) personality (virtio-1)

2019-08-01 Thread Sergio Lopez
Laszlo Ersek writes: > On 07/29/19 14:57, Sergio Lopez wrote: >> Implement the modern (v2) personality, according to the VirtIO 1.0 >> specification. >> >> Support for v2 among guests is not as widespread as it'd be >> desirable. While the Linux driver has had it for a while, support is >>

Re: [Qemu-devel] [RFC] virtio-mmio: implement modern (v2) personality (virtio-1)

2019-08-01 Thread Cornelia Huck
On Wed, 31 Jul 2019 15:06:11 -0400 "Michael S. Tsirkin" wrote: > On Wed, Jul 31, 2019 at 03:55:51PM +0200, Cornelia Huck wrote: > > On Tue, 30 Jul 2019 16:18:52 -0400 > > "Michael S. Tsirkin" wrote: > > > Make sure your guests > > > are all up to date in preparation to the day when legacy will

Re: [Qemu-devel] [RFC] virtio-mmio: implement modern (v2) personality (virtio-1)

2019-07-31 Thread Paolo Bonzini
On 30/07/19 18:06, Laszlo Ersek wrote: > On 07/29/19 14:57, Sergio Lopez wrote: >> Implement the modern (v2) personality, according to the VirtIO 1.0 >> specification. >> >> Support for v2 among guests is not as widespread as it'd be >> desirable. While the Linux driver has had it for a while,

Re: [Qemu-devel] [RFC] virtio-mmio: implement modern (v2) personality (virtio-1)

2019-07-31 Thread Eduardo Habkost
On Wed, Jul 31, 2019 at 02:22:09PM +0200, Sergio Lopez wrote: > > Michael S. Tsirkin writes: > > > On Mon, Jul 29, 2019 at 02:57:55PM +0200, Sergio Lopez wrote: > >> Implement the modern (v2) personality, according to the VirtIO 1.0 > >> specification. > >> > >> Support for v2 among guests is

Re: [Qemu-devel] [RFC] virtio-mmio: implement modern (v2) personality (virtio-1)

2019-07-31 Thread Michael S. Tsirkin
On Wed, Jul 31, 2019 at 02:22:09PM +0200, Sergio Lopez wrote: > > Michael S. Tsirkin writes: > > > On Mon, Jul 29, 2019 at 02:57:55PM +0200, Sergio Lopez wrote: > >> Implement the modern (v2) personality, according to the VirtIO 1.0 > >> specification. > >> > >> Support for v2 among guests is

Re: [Qemu-devel] [RFC] virtio-mmio: implement modern (v2) personality (virtio-1)

2019-07-31 Thread Michael S. Tsirkin
On Wed, Jul 31, 2019 at 03:55:51PM +0200, Cornelia Huck wrote: > On Tue, 30 Jul 2019 16:18:52 -0400 > "Michael S. Tsirkin" wrote: > > > On Tue, Jul 30, 2019 at 03:14:00PM +0200, Cornelia Huck wrote: > > > On Tue, 30 Jul 2019 14:17:48 +0200 > > > Andrea Bolognani wrote: > > > > > > > On Tue,

Re: [Qemu-devel] [RFC] virtio-mmio: implement modern (v2) personality (virtio-1)

2019-07-31 Thread Cornelia Huck
On Tue, 30 Jul 2019 16:18:52 -0400 "Michael S. Tsirkin" wrote: > On Tue, Jul 30, 2019 at 03:14:00PM +0200, Cornelia Huck wrote: > > On Tue, 30 Jul 2019 14:17:48 +0200 > > Andrea Bolognani wrote: > > > > > On Tue, 2019-07-30 at 13:35 +0200, Cornelia Huck wrote: > > > > On Tue, 30 Jul 2019

Re: [Qemu-devel] [RFC] virtio-mmio: implement modern (v2) personality (virtio-1)

2019-07-31 Thread Sergio Lopez
Michael S. Tsirkin writes: > On Mon, Jul 29, 2019 at 02:57:55PM +0200, Sergio Lopez wrote: >> Implement the modern (v2) personality, according to the VirtIO 1.0 >> specification. >> >> Support for v2 among guests is not as widespread as it'd be >> desirable. While the Linux driver has had it

Re: [Qemu-devel] [RFC] virtio-mmio: implement modern (v2) personality (virtio-1)

2019-07-31 Thread Sergio Lopez
Michael S. Tsirkin writes: > On Tue, Jul 30, 2019 at 03:14:00PM +0200, Cornelia Huck wrote: >> On Tue, 30 Jul 2019 14:17:48 +0200 >> Andrea Bolognani wrote: >> >> > On Tue, 2019-07-30 at 13:35 +0200, Cornelia Huck wrote: >> > > On Tue, 30 Jul 2019 12:25:30 +0200 >> > > Andrea Bolognani

Re: [Qemu-devel] [RFC] virtio-mmio: implement modern (v2) personality (virtio-1)

2019-07-31 Thread Sergio Lopez
Andrea Bolognani writes: > On Mon, 2019-07-29 at 14:57 +0200, Sergio Lopez wrote: > [...] >> /* virtio-mmio device */ >> >> static Property virtio_mmio_properties[] = { >> DEFINE_PROP_BOOL("format_transport_address", VirtIOMMIOProxy, >> format_transport_address,

Re: [Qemu-devel] [RFC] virtio-mmio: implement modern (v2) personality (virtio-1)

2019-07-30 Thread Michael S. Tsirkin
On Tue, Jul 30, 2019 at 03:14:00PM +0200, Cornelia Huck wrote: > On Tue, 30 Jul 2019 14:17:48 +0200 > Andrea Bolognani wrote: > > > On Tue, 2019-07-30 at 13:35 +0200, Cornelia Huck wrote: > > > On Tue, 30 Jul 2019 12:25:30 +0200 > > > Andrea Bolognani wrote: > > > > Can you please make sure

Re: [Qemu-devel] [RFC] virtio-mmio: implement modern (v2) personality (virtio-1)

2019-07-30 Thread Michael S. Tsirkin
On Tue, Jul 30, 2019 at 03:14:00PM +0200, Cornelia Huck wrote: > On Tue, 30 Jul 2019 14:17:48 +0200 > Andrea Bolognani wrote: > > > On Tue, 2019-07-30 at 13:35 +0200, Cornelia Huck wrote: > > > On Tue, 30 Jul 2019 12:25:30 +0200 > > > Andrea Bolognani wrote: > > > > Can you please make sure

Re: [Qemu-devel] [RFC] virtio-mmio: implement modern (v2) personality (virtio-1)

2019-07-30 Thread Laszlo Ersek
On 07/29/19 14:57, Sergio Lopez wrote: > Implement the modern (v2) personality, according to the VirtIO 1.0 > specification. > > Support for v2 among guests is not as widespread as it'd be > desirable. While the Linux driver has had it for a while, support is > missing, at least, from Tianocore

Re: [Qemu-devel] [RFC] virtio-mmio: implement modern (v2) personality (virtio-1)

2019-07-30 Thread Cornelia Huck
On Tue, 30 Jul 2019 14:17:48 +0200 Andrea Bolognani wrote: > On Tue, 2019-07-30 at 13:35 +0200, Cornelia Huck wrote: > > On Tue, 30 Jul 2019 12:25:30 +0200 > > Andrea Bolognani wrote: > > > Can you please make sure virtio-mmio uses the existing interface > > > instead of introducing a new

Re: [Qemu-devel] [RFC] virtio-mmio: implement modern (v2) personality (virtio-1)

2019-07-30 Thread Andrea Bolognani
On Tue, 2019-07-30 at 13:35 +0200, Cornelia Huck wrote: > On Tue, 30 Jul 2019 12:25:30 +0200 > Andrea Bolognani wrote: > > Can you please make sure virtio-mmio uses the existing interface > > instead of introducing a new one? > > FWIW, I really hate virtio-pci's disable-modern/disable-legacy...

Re: [Qemu-devel] [RFC] virtio-mmio: implement modern (v2) personality (virtio-1)

2019-07-30 Thread Cornelia Huck
On Tue, 30 Jul 2019 12:25:30 +0200 Andrea Bolognani wrote: > On Mon, 2019-07-29 at 14:57 +0200, Sergio Lopez wrote: > [...] > > /* virtio-mmio device */ > > > > static Property virtio_mmio_properties[] = { > > DEFINE_PROP_BOOL("format_transport_address", VirtIOMMIOProxy, > >

Re: [Qemu-devel] [RFC] virtio-mmio: implement modern (v2) personality (virtio-1)

2019-07-30 Thread Andrea Bolognani
On Mon, 2019-07-29 at 14:57 +0200, Sergio Lopez wrote: [...] > /* virtio-mmio device */ > > static Property virtio_mmio_properties[] = { > DEFINE_PROP_BOOL("format_transport_address", VirtIOMMIOProxy, > format_transport_address, true), > +

Re: [Qemu-devel] [RFC] virtio-mmio: implement modern (v2) personality (virtio-1)

2019-07-30 Thread Michael S. Tsirkin
On Mon, Jul 29, 2019 at 02:57:55PM +0200, Sergio Lopez wrote: > Implement the modern (v2) personality, according to the VirtIO 1.0 > specification. > > Support for v2 among guests is not as widespread as it'd be > desirable. While the Linux driver has had it for a while, support is > missing, at

Re: [Qemu-devel] [RFC] virtio-mmio: implement modern (v2) personality (virtio-1)

2019-07-30 Thread Stefan Hajnoczi
On Mon, Jul 29, 2019 at 02:57:55PM +0200, Sergio Lopez wrote: > @@ -162,12 +183,34 @@ static uint64_t virtio_mmio_read(void *opaque, hwaddr > offset, unsigned size) > } > return VIRTQUEUE_MAX_SIZE; > case VIRTIO_MMIO_QUEUE_PFN: > +if (proxy->modern) { > +

Re: [Qemu-devel] [RFC] virtio-mmio: implement modern (v2) personality (virtio-1)

2019-07-29 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190729125755.45008-1-...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [RFC] virtio-mmio: implement modern (v2) personality (virtio-1) Message-id

[Qemu-devel] [RFC] virtio-mmio: implement modern (v2) personality (virtio-1)

2019-07-29 Thread Sergio Lopez
Implement the modern (v2) personality, according to the VirtIO 1.0 specification. Support for v2 among guests is not as widespread as it'd be desirable. While the Linux driver has had it for a while, support is missing, at least, from Tianocore EDK II, NetBSD and FreeBSD. For this reason, the v2