Re: [Qemu-devel] [RFC 00/13] aio: drop io_flush()

2013-04-12 Thread Stefan Hajnoczi
On Fri, Apr 12, 2013 at 2:22 PM, Kevin Wolf wrote: > Am 12.04.2013 um 14:06 hat Stefan Hajnoczi geschrieben: >> On Fri, Apr 12, 2013 at 12:27 PM, Paolo Bonzini wrote: >> > Il 12/04/2013 12:04, Kevin Wolf ha scritto: >> >> Or actually, if you want to avoid .bdrv_drain for now, the patch that I >>

Re: [Qemu-devel] [RFC 00/13] aio: drop io_flush()

2013-04-12 Thread Kevin Wolf
Am 12.04.2013 um 14:06 hat Stefan Hajnoczi geschrieben: > On Fri, Apr 12, 2013 at 12:27 PM, Paolo Bonzini wrote: > > Il 12/04/2013 12:04, Kevin Wolf ha scritto: > >> Or actually, if you want to avoid .bdrv_drain for now, the patch that I > >> started when I thought a bit about this, had a default

Re: [Qemu-devel] [RFC 00/13] aio: drop io_flush()

2013-04-12 Thread Stefan Hajnoczi
On Fri, Apr 12, 2013 at 12:27 PM, Paolo Bonzini wrote: > Il 12/04/2013 12:04, Kevin Wolf ha scritto: >> Or actually, if you want to avoid .bdrv_drain for now, the patch that I >> started when I thought a bit about this, had a default .bdrv_drain >> implementation that just forwarded the request to

Re: [Qemu-devel] [RFC 00/13] aio: drop io_flush()

2013-04-12 Thread Paolo Bonzini
Il 12/04/2013 12:04, Kevin Wolf ha scritto: > Or actually, if you want to avoid .bdrv_drain for now, the patch that I > started when I thought a bit about this, had a default .bdrv_drain > implementation that just forwarded the request to bs->file if it wasn't > implemented by a block driver. For t

Re: [Qemu-devel] [RFC 00/13] aio: drop io_flush()

2013-04-12 Thread Kevin Wolf
Am 12.04.2013 um 11:49 hat Stefan Hajnoczi geschrieben: > On Fri, Apr 12, 2013 at 10:02:02AM +0200, Kevin Wolf wrote: > > Am 11.04.2013 um 17:44 hat Stefan Hajnoczi geschrieben: > > > Here's my entry to the "let's get rid of io_flush()" effort. It's based > > > on > > > Paolo's insight about bdrv

Re: [Qemu-devel] [RFC 00/13] aio: drop io_flush()

2013-04-12 Thread Stefan Hajnoczi
On Fri, Apr 12, 2013 at 10:02:02AM +0200, Kevin Wolf wrote: > Am 11.04.2013 um 17:44 hat Stefan Hajnoczi geschrieben: > > Here's my entry to the "let's get rid of io_flush()" effort. It's based on > > Paolo's insight about bdrv_drain_all() that the block layer already has a > > tracked_requests li

Re: [Qemu-devel] [RFC 00/13] aio: drop io_flush()

2013-04-12 Thread Kevin Wolf
Am 11.04.2013 um 17:44 hat Stefan Hajnoczi geschrieben: > Here's my entry to the "let's get rid of io_flush()" effort. It's based on > Paolo's insight about bdrv_drain_all() that the block layer already has a > tracked_requests list. io_flush() is redundant since the block layer already > knows i

[Qemu-devel] [RFC 00/13] aio: drop io_flush()

2013-04-11 Thread Stefan Hajnoczi
Here's my entry to the "let's get rid of io_flush()" effort. It's based on Paolo's insight about bdrv_drain_all() that the block layer already has a tracked_requests list. io_flush() is redundant since the block layer already knows if requests are pending. The point of this effort is to simplify