Re: [Qemu-devel] [RFC 01/10] ide: add is_write() macro for semantic consistency

2014-09-13 Thread John Snow
On 09/13/2014 08:54 AM, Paolo Bonzini wrote: Il 13/09/2014 06:34, John Snow ha scritto: The prepare_buf callback takes an argument named /is_write/, however in core.c we are checking to see if this DMA command is /is_read/. I am adding a small macro to correct this oversight. Impact: Nothing,

Re: [Qemu-devel] [RFC 01/10] ide: add is_write() macro for semantic consistency

2014-09-13 Thread Paolo Bonzini
Il 13/09/2014 06:34, John Snow ha scritto: > The prepare_buf callback takes an argument named /is_write/, > however in core.c we are checking to see if this DMA command > is /is_read/. I am adding a small macro to correct this oversight. > > Impact: Nothing, yet. > -The prepare_buf callback is onl

[Qemu-devel] [RFC 01/10] ide: add is_write() macro for semantic consistency

2014-09-12 Thread John Snow
The prepare_buf callback takes an argument named /is_write/, however in core.c we are checking to see if this DMA command is /is_read/. I am adding a small macro to correct this oversight. Impact: Nothing, yet. -The prepare_buf callback is only used in ahci and pci, and both versions of this call