[Qemu-devel] [RFC 01/14] vga: Create direct sufaces for depth 24 too

2014-06-23 Thread Benjamin Herrenschmidt
pixman supports 24bpp directly, let's share surfaces For both endians even ! Signed-off-by: Benjamin Herrenschmidt --- hw/display/vga.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/display/vga.c b/hw/display/vga.c index e4cd206..4674576 100644 --- a/hw/display/vga.c +

Re: [Qemu-devel] [RFC 01/14] vga: Create direct sufaces for depth 24 too

2014-07-01 Thread Gerd Hoffmann
Hi, > -if (depth == 32 || ((depth == 16 || depth == 15) && !byteswap)) { > + if (depth == 32 || depth == 24 || > + ((depth == 16 || depth == 15) && !byteswap)) { Doesn't apply. depth == 15 isn't upstream. Guess you have some more local changes? Also the whitespace looks

Re: [Qemu-devel] [RFC 01/14] vga: Create direct sufaces for depth 24 too

2014-07-01 Thread Benjamin Herrenschmidt
On Tue, 2014-07-01 at 09:09 +0200, Gerd Hoffmann wrote: > Hi, > > > -if (depth == 32 || ((depth == 16 || depth == 15) && !byteswap)) { > > + if (depth == 32 || depth == 24 || > > + ((depth == 16 || depth == 15) && !byteswap)) { > > Doesn't apply. > depth == 15 isn't upstr