Re: [Qemu-devel] [RFC 02/10] AHCI: Update byte count after DMA completion

2014-09-16 Thread Paolo Bonzini
Il 15/09/2014 22:07, John Snow ha scritto: >>> >>> -/* free sglist that was created in ahci_populate_sglist() */ >>> -qemu_sglist_destroy(&s->sg); >>> +/* free sglist, update byte count */ >>> +ahci_commit_buf(dma, true); >> >> Perhaps you should make dma_buf_commit public (and add

Re: [Qemu-devel] [RFC 02/10] AHCI: Update byte count after DMA completion

2014-09-15 Thread John Snow
On 09/13/2014 09:21 AM, Paolo Bonzini wrote: Il 13/09/2014 06:34, John Snow ha scritto: Currently, DMA read/write operations neglect to update the byte count after a successful transfer like ATAPI DMA read or PIO read/write operations do. We correct this oversight by adding another callback i

Re: [Qemu-devel] [RFC 02/10] AHCI: Update byte count after DMA completion

2014-09-13 Thread Paolo Bonzini
Il 13/09/2014 06:34, John Snow ha scritto: > Currently, DMA read/write operations neglect to update > the byte count after a successful transfer like ATAPI > DMA read or PIO read/write operations do. > > We correct this oversight by adding another callback into > the IDEDMAOps structure. The commi

[Qemu-devel] [RFC 02/10] AHCI: Update byte count after DMA completion

2014-09-12 Thread John Snow
Currently, DMA read/write operations neglect to update the byte count after a successful transfer like ATAPI DMA read or PIO read/write operations do. We correct this oversight by adding another callback into the IDEDMAOps structure. The commit callback is called whenever we are cleaning up a scat