Re: [Qemu-devel] [RFC 03/10] AHCI: Add PRD interrupt

2014-09-16 Thread Paolo Bonzini
Il 15/09/2014 18:31, John Snow ha scritto: > > > On 09/13/2014 03:50 PM, Paolo Bonzini wrote: >> Il 13/09/2014 15:26, Paolo Bonzini ha scritto: > > +if (ad->dp_intr_req) { > +ahci_trigger_irq(ad->hba, ad, PORT_IRQ_SG_DONE); > +ad->dp_intr_req = 0; > +}

Re: [Qemu-devel] [RFC 03/10] AHCI: Add PRD interrupt

2014-09-15 Thread John Snow
On 09/13/2014 03:50 PM, Paolo Bonzini wrote: Il 13/09/2014 15:26, Paolo Bonzini ha scritto: +if (ad->dp_intr_req) { +ahci_trigger_irq(ad->hba, ad, PORT_IRQ_SG_DONE); +ad->dp_intr_req = 0; +} Is it also needed in the error case? Especially the short-PRDT case that you

Re: [Qemu-devel] [RFC 03/10] AHCI: Add PRD interrupt

2014-09-15 Thread John Snow
On 09/13/2014 09:26 AM, Paolo Bonzini wrote: Il 13/09/2014 06:34, John Snow ha scritto: AHCI devices support a feature where individual entries in the scatter-gather list may have interrupt request bits set, in order to receive notification partway through a command that a portion of a transfe

Re: [Qemu-devel] [RFC 03/10] AHCI: Add PRD interrupt

2014-09-13 Thread Paolo Bonzini
Il 13/09/2014 15:26, Paolo Bonzini ha scritto: >> > >> > +if (ad->dp_intr_req) { >> > +ahci_trigger_irq(ad->hba, ad, PORT_IRQ_SG_DONE); >> > +ad->dp_intr_req = 0; >> > +} > Is it also needed in the error case? Especially the short-PRDT case > that you are adding in the ne

Re: [Qemu-devel] [RFC 03/10] AHCI: Add PRD interrupt

2014-09-13 Thread Paolo Bonzini
Il 13/09/2014 06:34, John Snow ha scritto: > AHCI devices support a feature where individual entries in the > scatter-gather list may have interrupt request bits set, in order > to receive notification partway through a command that a portion > of a transfer has completed. AHCI specs refer to this

[Qemu-devel] [RFC 03/10] AHCI: Add PRD interrupt

2014-09-12 Thread John Snow
AHCI devices support a feature where individual entries in the scatter-gather list may have interrupt request bits set, in order to receive notification partway through a command that a portion of a transfer has completed. AHCI specs refer to this as the DPS bit or Descriptor Processed Status. It i