[Qemu-devel] [RFC 1/2] qbus_find_recursive(): don't abort search for named bus on full bus node

2013-01-31 Thread Laszlo Ersek
The bus we're looking for could be in the sub-tree rooted at the node being checked; don't skip looping over the children. Signed-off-by: Laszlo Ersek ler...@redhat.com --- hw/qdev-monitor.c | 10 +- 1 files changed, 1 insertions(+), 9 deletions(-) diff --git a/hw/qdev-monitor.c

Re: [Qemu-devel] [RFC 1/2] qbus_find_recursive(): don't abort search for named bus on full bus node

2013-01-31 Thread Peter Maydell
On 31 January 2013 15:42, Laszlo Ersek ler...@redhat.com wrote: The bus we're looking for could be in the sub-tree rooted at the node being checked; don't skip looping over the children. Signed-off-by: Laszlo Ersek ler...@redhat.com --- hw/qdev-monitor.c | 10 + 1 files changed,

Re: [Qemu-devel] [RFC 1/2] qbus_find_recursive(): don't abort search for named bus on full bus node

2013-01-31 Thread Laszlo Ersek
On 01/31/13 16:52, Peter Maydell wrote: On 31 January 2013 15:42, Laszlo Ersek ler...@redhat.com wrote: The bus we're looking for could be in the sub-tree rooted at the node being checked; don't skip looping over the children. Signed-off-by: Laszlo Ersek ler...@redhat.com ---

Re: [Qemu-devel] [RFC 1/2] qbus_find_recursive(): don't abort search for named bus on full bus node

2013-01-31 Thread Peter Maydell
On 31 January 2013 15:58, KONRAD Frédéric fred.kon...@greensocs.com wrote: On 31/01/2013 16:52, Peter Maydell wrote: On 31 January 2013 15:42, Laszlo Ersek ler...@redhat.com wrote: The bus we're looking for could be in the sub-tree rooted at the node being checked; don't skip looping over

Re: [Qemu-devel] [RFC 1/2] qbus_find_recursive(): don't abort search for named bus on full bus node

2013-01-31 Thread Peter Maydell
On 31 January 2013 16:05, Laszlo Ersek ler...@redhat.com wrote: On 01/31/13 16:52, Peter Maydell wrote: This looks like the wrong fix to this problem -- if the user passed us a specific name to search for and we found it and it was full, then we definitely want to stop here. You only skip

Re: [Qemu-devel] [RFC 1/2] qbus_find_recursive(): don't abort search for named bus on full bus node

2013-01-31 Thread KONRAD Frédéric
On 31/01/2013 16:52, Peter Maydell wrote: On 31 January 2013 15:42, Laszlo Ersek ler...@redhat.com wrote: The bus we're looking for could be in the sub-tree rooted at the node being checked; don't skip looping over the children. Signed-off-by: Laszlo Ersek ler...@redhat.com ---

Re: [Qemu-devel] [RFC 1/2] qbus_find_recursive(): don't abort search for named bus on full bus node

2013-01-31 Thread Laszlo Ersek
On 01/31/13 17:09, Peter Maydell wrote: On 31 January 2013 16:05, Laszlo Ersek ler...@redhat.com wrote: On 01/31/13 16:52, Peter Maydell wrote: This looks like the wrong fix to this problem -- if the user passed us a specific name to search for and we found it and it was full, then we