Re: [Qemu-devel] [RFC 1/3] block: Add ImageRotationalInfo

2019-05-31 Thread Kevin Wolf
Am 31.05.2019 um 13:51 hat Max Reitz geschrieben: > On 30.05.19 00:10, Kevin Wolf wrote: > > Am 24.05.2019 um 19:28 hat Max Reitz geschrieben: > >> This enum indicates whether a file is stored on a rotating disk or a > >> solid-state drive. Drivers report it via the .bdrv_get_info() callback, > >>

Re: [Qemu-devel] [RFC 1/3] block: Add ImageRotationalInfo

2019-05-31 Thread Max Reitz
On 30.05.19 00:10, Kevin Wolf wrote: > Am 24.05.2019 um 19:28 hat Max Reitz geschrieben: >> This enum indicates whether a file is stored on a rotating disk or a >> solid-state drive. Drivers report it via the .bdrv_get_info() callback, >> and if they do not, the global bdrv_get_info() implementati

Re: [Qemu-devel] [RFC 1/3] block: Add ImageRotationalInfo

2019-05-29 Thread Kevin Wolf
Am 24.05.2019 um 19:28 hat Max Reitz geschrieben: > This enum indicates whether a file is stored on a rotating disk or a > solid-state drive. Drivers report it via the .bdrv_get_info() callback, > and if they do not, the global bdrv_get_info() implementation > automatically takes it from bs->file

Re: [Qemu-devel] [RFC 1/3] block: Add ImageRotationalInfo

2019-05-27 Thread Alberto Garcia
On Mon 27 May 2019 03:44:59 PM CEST, Anton Nefedov wrote: >> I think in general optimizing for SSDs should probably be the >> default. HDDs are slow anyway, so whoever uses them probably doesn’t >> care about performance too much anyway...? Whereas people using SSDs >> probably do. But as I said

Re: [Qemu-devel] [RFC 1/3] block: Add ImageRotationalInfo

2019-05-27 Thread Max Reitz
On 27.05.19 15:44, Anton Nefedov wrote: > On 27/5/2019 3:57 PM, Max Reitz wrote: >> On 27.05.19 14:37, Alberto Garcia wrote: >>> On Mon 27 May 2019 02:16:53 PM CEST, Max Reitz wrote: On 26.05.19 17:08, Alberto Garcia wrote: > On Fri 24 May 2019 07:28:10 PM CEST, Max Reitz wrote: >> +#

Re: [Qemu-devel] [RFC 1/3] block: Add ImageRotationalInfo

2019-05-27 Thread Anton Nefedov
On 27/5/2019 3:57 PM, Max Reitz wrote: > On 27.05.19 14:37, Alberto Garcia wrote: >> On Mon 27 May 2019 02:16:53 PM CEST, Max Reitz wrote: >>> On 26.05.19 17:08, Alberto Garcia wrote: On Fri 24 May 2019 07:28:10 PM CEST, Max Reitz wrote: > +## > +# @ImageRotationalInfo: > +# >

Re: [Qemu-devel] [RFC 1/3] block: Add ImageRotationalInfo

2019-05-27 Thread Max Reitz
On 27.05.19 14:37, Alberto Garcia wrote: > On Mon 27 May 2019 02:16:53 PM CEST, Max Reitz wrote: >> On 26.05.19 17:08, Alberto Garcia wrote: >>> On Fri 24 May 2019 07:28:10 PM CEST, Max Reitz wrote: +## +# @ImageRotationalInfo: +# +# Indicates whether an image is stored on a ro

Re: [Qemu-devel] [RFC 1/3] block: Add ImageRotationalInfo

2019-05-27 Thread Alberto Garcia
On Mon 27 May 2019 02:16:53 PM CEST, Max Reitz wrote: > On 26.05.19 17:08, Alberto Garcia wrote: >> On Fri 24 May 2019 07:28:10 PM CEST, Max Reitz wrote: >>> +## >>> +# @ImageRotationalInfo: >>> +# >>> +# Indicates whether an image is stored on a rotating disk or not. >>> +# >>> +# @solid-state: I

Re: [Qemu-devel] [RFC 1/3] block: Add ImageRotationalInfo

2019-05-27 Thread Max Reitz
On 26.05.19 17:08, Alberto Garcia wrote: > On Fri 24 May 2019 07:28:10 PM CEST, Max Reitz wrote: >> +## >> +# @ImageRotationalInfo: >> +# >> +# Indicates whether an image is stored on a rotating disk or not. >> +# >> +# @solid-state: Image is stored on a solid-state drive >> +# >> +# @rotating:

Re: [Qemu-devel] [RFC 1/3] block: Add ImageRotationalInfo

2019-05-26 Thread Alberto Garcia
On Fri 24 May 2019 07:28:10 PM CEST, Max Reitz wrote: > +## > +# @ImageRotationalInfo: > +# > +# Indicates whether an image is stored on a rotating disk or not. > +# > +# @solid-state: Image is stored on a solid-state drive > +# > +# @rotating:Image is stored on a rotating disk What happens w

[Qemu-devel] [RFC 1/3] block: Add ImageRotationalInfo

2019-05-24 Thread Max Reitz
This enum indicates whether a file is stored on a rotating disk or a solid-state drive. Drivers report it via the .bdrv_get_info() callback, and if they do not, the global bdrv_get_info() implementation automatically takes it from bs->file or bs->backing, if available. On the QAPI side, we report