Re: [Qemu-devel] [RFC 1/3] spapr: Fold spapr_phb_add_pci_device() into its only caller

2017-06-07 Thread Michael Roth
Quoting David Gibson (2017-06-06 20:33:07) > On Tue, Jun 06, 2017 at 04:37:27PM -0500, Michael Roth wrote: > > Quoting David Gibson (2017-06-06 08:05:32) > > > This function is fairly short, and so is its only caller. There's no > > > particular logical distinction between them, so fold them

Re: [Qemu-devel] [RFC 1/3] spapr: Fold spapr_phb_add_pci_device() into its only caller

2017-06-06 Thread David Gibson
On Tue, Jun 06, 2017 at 04:37:27PM -0500, Michael Roth wrote: > Quoting David Gibson (2017-06-06 08:05:32) > > This function is fairly short, and so is its only caller. There's no > > particular logical distinction between them, so fold them together. > > > > Signed-off-by: David Gibson

Re: [Qemu-devel] [RFC 1/3] spapr: Fold spapr_phb_add_pci_device() into its only caller

2017-06-06 Thread Michael Roth
Quoting David Gibson (2017-06-06 08:05:32) > This function is fairly short, and so is its only caller. There's no > particular logical distinction between them, so fold them together. > > Signed-off-by: David Gibson > --- > hw/ppc/spapr_pci.c | 53

[Qemu-devel] [RFC 1/3] spapr: Fold spapr_phb_add_pci_device() into its only caller

2017-06-06 Thread David Gibson
This function is fairly short, and so is its only caller. There's no particular logical distinction between them, so fold them together. Signed-off-by: David Gibson --- hw/ppc/spapr_pci.c | 53 ++--- 1 file changed,