Re: [Qemu-devel] [RFC 14/15] qmp: support out-of-band (oob) execution

2017-09-18 Thread Peter Xu
On Fri, Sep 15, 2017 at 04:55:51PM +0100, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > Having "allow-oob" to true for a command does not mean that this command > > will always be run in out-of-band mode. The out-of-band quick path will > > only be executed if we

Re: [Qemu-devel] [RFC 14/15] qmp: support out-of-band (oob) execution

2017-09-18 Thread Peter Xu
On Fri, Sep 15, 2017 at 01:34:24PM -0500, Eric Blake wrote: > On 09/14/2017 09:59 PM, Peter Xu wrote: > > On Thu, Sep 14, 2017 at 04:33:34PM +0100, Stefan Hajnoczi wrote: > >> On Thu, Sep 14, 2017 at 03:50:35PM +0800, Peter Xu wrote: > >>> diff --git a/docs/devel/qapi-code-gen.txt

Re: [Qemu-devel] [RFC 14/15] qmp: support out-of-band (oob) execution

2017-09-15 Thread Eric Blake
On 09/14/2017 09:59 PM, Peter Xu wrote: > On Thu, Sep 14, 2017 at 04:33:34PM +0100, Stefan Hajnoczi wrote: >> On Thu, Sep 14, 2017 at 03:50:35PM +0800, Peter Xu wrote: >>> diff --git a/docs/devel/qapi-code-gen.txt b/docs/devel/qapi-code-gen.txt >>> index 61fa167..47d16bb 100644 >>> ---

Re: [Qemu-devel] [RFC 14/15] qmp: support out-of-band (oob) execution

2017-09-15 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > Having "allow-oob" to true for a command does not mean that this command > will always be run in out-of-band mode. The out-of-band quick path will > only be executed if we specify the extra "run-oob" flag when sending the > QMP request: > > { "execute":

Re: [Qemu-devel] [RFC 14/15] qmp: support out-of-band (oob) execution

2017-09-14 Thread Peter Xu
On Thu, Sep 14, 2017 at 04:33:34PM +0100, Stefan Hajnoczi wrote: > On Thu, Sep 14, 2017 at 03:50:35PM +0800, Peter Xu wrote: > > diff --git a/docs/devel/qapi-code-gen.txt b/docs/devel/qapi-code-gen.txt > > index 61fa167..47d16bb 100644 > > --- a/docs/devel/qapi-code-gen.txt > > +++

Re: [Qemu-devel] [RFC 14/15] qmp: support out-of-band (oob) execution

2017-09-14 Thread Stefan Hajnoczi
On Thu, Sep 14, 2017 at 03:50:35PM +0800, Peter Xu wrote: > diff --git a/docs/devel/qapi-code-gen.txt b/docs/devel/qapi-code-gen.txt > index 61fa167..47d16bb 100644 > --- a/docs/devel/qapi-code-gen.txt > +++ b/docs/devel/qapi-code-gen.txt > @@ -665,6 +665,16 @@ allowed to run out-of-band can also

[Qemu-devel] [RFC 14/15] qmp: support out-of-band (oob) execution

2017-09-14 Thread Peter Xu
Having "allow-oob" to true for a command does not mean that this command will always be run in out-of-band mode. The out-of-band quick path will only be executed if we specify the extra "run-oob" flag when sending the QMP request: { "execute": "command-that-allows-oob", "arguments": { ...