Re: [Qemu-devel] [RFC 2/2] hw/i386: enforce SID verification

2016-08-10 Thread Peter Xu
On Wed, Aug 10, 2016 at 09:30:52AM +0300, David Kiarie wrote: > On Wed, Aug 10, 2016 at 8:49 AM, Peter Xu wrote: > > > On Tue, Aug 09, 2016 at 05:32:17PM +0300, David Kiarie wrote: > > > > [...] > > > > > @@ -2252,14 +2250,17 @@ static MemTxResult vtd_mem_ir_write(void > > *opaque, hwaddr addr, >

Re: [Qemu-devel] [RFC 2/2] hw/i386: enforce SID verification

2016-08-09 Thread David Kiarie
On Wed, Aug 10, 2016 at 8:49 AM, Peter Xu wrote: > On Tue, Aug 09, 2016 at 05:32:17PM +0300, David Kiarie wrote: > > [...] > > > @@ -2252,14 +2250,17 @@ static MemTxResult vtd_mem_ir_write(void > *opaque, hwaddr addr, > > { > > int ret = 0; > > MSIMessage from = {}, to = {}; > > -u

Re: [Qemu-devel] [RFC 2/2] hw/i386: enforce SID verification

2016-08-09 Thread Peter Xu
On Tue, Aug 09, 2016 at 05:32:17PM +0300, David Kiarie wrote: [...] > @@ -2252,14 +2250,17 @@ static MemTxResult vtd_mem_ir_write(void *opaque, > hwaddr addr, > { > int ret = 0; > MSIMessage from = {}, to = {}; > -uint16_t sid = X86_IOMMU_SID_INVALID; > +VTDAddressSpace *as =

Re: [Qemu-devel] [RFC 2/2] hw/i386: enforce SID verification

2016-08-09 Thread David Kiarie
On Tue, Aug 9, 2016 at 9:41 PM, Valentine Sinitsyn < valentine.sinit...@gmail.com> wrote: > > > On 09.08.2016 19:32, David Kiarie wrote: > >> Platform device are now able to make interrupt request with >> explicit SIDs hence we can safely expect triggered AddressSpace ID >> to match the requesting

Re: [Qemu-devel] [RFC 2/2] hw/i386: enforce SID verification

2016-08-09 Thread Valentine Sinitsyn
On 09.08.2016 19:32, David Kiarie wrote: Platform device are now able to make interrupt request with explicit SIDs hence we can safely expect triggered AddressSpace ID to match the requesting ID Signed-off-by: David Kiarie --- hw/i386/intel_iommu.c | 82 +++---

[Qemu-devel] [RFC 2/2] hw/i386: enforce SID verification

2016-08-09 Thread David Kiarie
Platform device are now able to make interrupt request with explicit SIDs hence we can safely expect triggered AddressSpace ID to match the requesting ID Signed-off-by: David Kiarie --- hw/i386/intel_iommu.c | 82 +++ 1 file changed, 43 insertions(