Re: [Qemu-devel] [RFC 2/3] hw/char/nrf51_uart: Implement nRF51 SoC UART

2018-06-02 Thread Stefan Hajnoczi
On Fri, Jun 1, 2018 at 4:58 PM, Peter Maydell wrote: > On 1 June 2018 at 16:21, Julia Suvorova wrote: >> On 31.05.2018 12:42, Stefan Hajnoczi wrote: +static int uart_can_receive(void *opaque) +{ +Nrf51UART *s = NRF51_UART(opaque); + +return (s->rx_fifo_len < sizeo

Re: [Qemu-devel] [RFC 2/3] hw/char/nrf51_uart: Implement nRF51 SoC UART

2018-06-01 Thread Peter Maydell
On 1 June 2018 at 16:21, Julia Suvorova wrote: > On 31.05.2018 12:42, Stefan Hajnoczi wrote: >> Please add a comment here: >> >>/* The hardware has no transmit error reporting, so silently drop the >> byte */ >> > > The QEMU code is inconsistent with comments. Some files are full of > comments

Re: [Qemu-devel] [RFC 2/3] hw/char/nrf51_uart: Implement nRF51 SoC UART

2018-06-01 Thread Julia Suvorova via Qemu-devel
On 01.06.2018 13:44, Stefan Hajnoczi wrote: On Fri, Jun 1, 2018 at 11:41 AM, Stefan Hajnoczi wrote: On Thu, May 31, 2018 at 2:58 PM, sundeep subbaraya wrote: On Wed, May 30, 2018 at 3:33 AM, Julia Suvorova via Qemu-devel wrote: +static uint64_t uart_read(void *opaque, hwaddr addr, unsigned

Re: [Qemu-devel] [RFC 2/3] hw/char/nrf51_uart: Implement nRF51 SoC UART

2018-06-01 Thread Julia Suvorova via Qemu-devel
On 31.05.2018 12:42, Stefan Hajnoczi wrote: > On Wed, May 30, 2018 at 01:03:37AM +0300, Julia Suvorova wrote: >> The following features are not yet implemented: >> Control with SUSPEND/START*/STOP* > > This is probably worth implementing for completeness. Just rx_enabled > and tx_enabled boo

Re: [Qemu-devel] [RFC 2/3] hw/char/nrf51_uart: Implement nRF51 SoC UART

2018-06-01 Thread Stefan Hajnoczi
On Fri, Jun 1, 2018 at 11:41 AM, Stefan Hajnoczi wrote: > On Thu, May 31, 2018 at 2:58 PM, sundeep subbaraya > wrote: >> On Wed, May 30, 2018 at 3:33 AM, Julia Suvorova via Qemu-devel >> wrote: >>> +static uint64_t uart_read(void *opaque, hwaddr addr, unsigned int size) >>> +{ >>> +Nrf51UART

Re: [Qemu-devel] [RFC 2/3] hw/char/nrf51_uart: Implement nRF51 SoC UART

2018-06-01 Thread Stefan Hajnoczi
On Thu, May 31, 2018 at 2:58 PM, sundeep subbaraya wrote: > On Wed, May 30, 2018 at 3:33 AM, Julia Suvorova via Qemu-devel > wrote: >> +static uint64_t uart_read(void *opaque, hwaddr addr, unsigned int size) >> +{ >> +Nrf51UART *s = NRF51_UART(opaque); >> +uint64_t r; >> + >> +switch

Re: [Qemu-devel] [RFC 2/3] hw/char/nrf51_uart: Implement nRF51 SoC UART

2018-05-31 Thread sundeep subbaraya
Hi, On Wed, May 30, 2018 at 3:33 AM, Julia Suvorova via Qemu-devel wrote: > Basic implementation of nRF51 SoC UART. > Description could be found here: > http://infocenter.nordicsemi.com/pdf/nRF51_RM_v3.0.1.pdf > > The following features are not yet implemented: > Control with SUSPEND/START*/S

Re: [Qemu-devel] [RFC 2/3] hw/char/nrf51_uart: Implement nRF51 SoC UART

2018-05-31 Thread Peter Maydell
On 29 May 2018 at 23:03, Julia Suvorova wrote: > Basic implementation of nRF51 SoC UART. > Description could be found here: > http://infocenter.nordicsemi.com/pdf/nRF51_RM_v3.0.1.pdf > > The following features are not yet implemented: > Control with SUSPEND/START*/STOP* > CTS/NCTS flow con

Re: [Qemu-devel] [RFC 2/3] hw/char/nrf51_uart: Implement nRF51 SoC UART

2018-05-31 Thread Stefan Hajnoczi
On Wed, May 30, 2018 at 01:03:37AM +0300, Julia Suvorova wrote: > The following features are not yet implemented: > Control with SUSPEND/START*/STOP* This is probably worth implementing for completeness. Just rx_enabled and tx_enabled boolean states will be sufficient. SUSPEND flushes tx and

[Qemu-devel] [RFC 2/3] hw/char/nrf51_uart: Implement nRF51 SoC UART

2018-05-29 Thread Julia Suvorova via Qemu-devel
Basic implementation of nRF51 SoC UART. Description could be found here: http://infocenter.nordicsemi.com/pdf/nRF51_RM_v3.0.1.pdf The following features are not yet implemented: Control with SUSPEND/START*/STOP* CTS/NCTS flow control Mapping registers to pins Signed-off-by: Julia Suvo