Re: [Qemu-devel] [RFC 2/5] virtio-balloon: Corrections to address verification

2018-10-12 Thread David Gibson
On Fri, Oct 12, 2018 at 09:44:25AM +0200, David Hildenbrand wrote: > On 12/10/2018 05:24, David Gibson wrote: > > The virtio-balloon device's verification of the address given to it by the > > guest has a number of faults: > > * The addresses here are guest physical addresses, which should be >

Re: [Qemu-devel] [RFC 2/5] virtio-balloon: Corrections to address verification

2018-10-12 Thread David Hildenbrand
On 12/10/2018 05:24, David Gibson wrote: > The virtio-balloon device's verification of the address given to it by the > guest has a number of faults: > * The addresses here are guest physical addresses, which should be > 'hwaddr' rather than 'ram_addr_t' (the distinction is admittedly >

[Qemu-devel] [RFC 2/5] virtio-balloon: Corrections to address verification

2018-10-11 Thread David Gibson
The virtio-balloon device's verification of the address given to it by the guest has a number of faults: * The addresses here are guest physical addresses, which should be 'hwaddr' rather than 'ram_addr_t' (the distinction is admittedly pretty subtle and confusing) * We don't ch