Re: [Qemu-devel] [RFC 2 PATCH 05/16] hw/i386: Simplify topology Offset/width Calculation

2019-12-02 Thread Babu Moger
On 10/10/19 9:32 PM, Eduardo Habkost wrote: > On Fri, Sep 06, 2019 at 07:12:11PM +, Moger, Babu wrote: >> Some parameters are unnecessarily passed for offset/width >> calculation. Remove those parameters from function prototypes. >> No functional change. >> >> Signed-off-by: Babu Moger > >

Re: [Qemu-devel] [RFC 2 PATCH 05/16] hw/i386: Simplify topology Offset/width Calculation

2019-10-10 Thread Eduardo Habkost
On Fri, Sep 06, 2019 at 07:12:11PM +, Moger, Babu wrote: > Some parameters are unnecessarily passed for offset/width > calculation. Remove those parameters from function prototypes. > No functional change. > > Signed-off-by: Babu Moger Isn't it simpler to use the new X86CPUTopoInfo struct, t

[Qemu-devel] [RFC 2 PATCH 05/16] hw/i386: Simplify topology Offset/width Calculation

2019-09-06 Thread Moger, Babu
Some parameters are unnecessarily passed for offset/width calculation. Remove those parameters from function prototypes. No functional change. Signed-off-by: Babu Moger --- include/hw/i386/topology.h | 45 ++-- target/i386/cpu.c | 12 -