Re: [Qemu-devel] [RFC 5/7] qxl-render: call ppm_save on callback

2012-02-22 Thread Luiz Capitulino
On Wed, 22 Feb 2012 17:35:15 +0100 Alon Levy wrote: > On Wed, Feb 22, 2012 at 01:55:45PM -0200, Luiz Capitulino wrote: > > On Wed, 22 Feb 2012 15:29:33 +0100 > > Alon Levy wrote: > > > > > On Wed, Feb 22, 2012 at 03:22:11PM +0100, Gerd Hoffmann wrote: > > > > Hi, > > > > > > > > > Honestly,

Re: [Qemu-devel] [RFC 5/7] qxl-render: call ppm_save on callback

2012-02-22 Thread Alon Levy
On Wed, Feb 22, 2012 at 01:55:45PM -0200, Luiz Capitulino wrote: > On Wed, 22 Feb 2012 15:29:33 +0100 > Alon Levy wrote: > > > On Wed, Feb 22, 2012 at 03:22:11PM +0100, Gerd Hoffmann wrote: > > > Hi, > > > > > > > Honestly, for this particular case, I'm not 100% sure that having an id > > > >

Re: [Qemu-devel] [RFC 5/7] qxl-render: call ppm_save on callback

2012-02-22 Thread Luiz Capitulino
On Wed, 22 Feb 2012 15:29:33 +0100 Alon Levy wrote: > On Wed, Feb 22, 2012 at 03:22:11PM +0100, Gerd Hoffmann wrote: > > Hi, > > > > > Honestly, for this particular case, I'm not 100% sure that having an id is > > > _required_, as I don't expect a client to submit multiple screendump calls > >

Re: [Qemu-devel] [RFC 5/7] qxl-render: call ppm_save on callback

2012-02-22 Thread Alon Levy
On Wed, Feb 22, 2012 at 03:47:08PM +0100, Gerd Hoffmann wrote: > Hi, > > > I was thinking to add a new command since I'll want to add the id, and > > if I'm already adding a new command I'll put in a display number too. > > Big question is what the display number is supposed to be ... > Ah, y

Re: [Qemu-devel] [RFC 5/7] qxl-render: call ppm_save on callback

2012-02-22 Thread Gerd Hoffmann
Hi, > I was thinking to add a new command since I'll want to add the id, and > if I'm already adding a new command I'll put in a display number too. Big question is what the display number is supposed to be ... cheers, Gerd

Re: [Qemu-devel] [RFC 5/7] qxl-render: call ppm_save on callback

2012-02-22 Thread Alon Levy
On Wed, Feb 22, 2012 at 03:22:11PM +0100, Gerd Hoffmann wrote: > Hi, > > > Honestly, for this particular case, I'm not 100% sure that having an id is > > _required_, as I don't expect a client to submit multiple screendump calls > > in parallel and we don't "officially" support multiple QMP clie

Re: [Qemu-devel] [RFC 5/7] qxl-render: call ppm_save on callback

2012-02-22 Thread Alon Levy
On Wed, Feb 22, 2012 at 11:49:27AM -0200, Luiz Capitulino wrote: > On Wed, 22 Feb 2012 14:22:50 +0100 > Alon Levy wrote: > > > On Wed, Feb 22, 2012 at 11:17:17AM -0200, Luiz Capitulino wrote: > > > On Tue, 21 Feb 2012 19:40:16 +0200 > > > Alon Levy wrote: > > > > > > > On Tue, Feb 21, 2012 at 0

Re: [Qemu-devel] [RFC 5/7] qxl-render: call ppm_save on callback

2012-02-22 Thread Gerd Hoffmann
Hi, > Honestly, for this particular case, I'm not 100% sure that having an id is > _required_, as I don't expect a client to submit multiple screendump calls > in parallel and we don't "officially" support multiple QMP clients either. > Also, having the screendump filename in the event will serv

Re: [Qemu-devel] [RFC 5/7] qxl-render: call ppm_save on callback

2012-02-22 Thread Luiz Capitulino
On Wed, 22 Feb 2012 14:22:50 +0100 Alon Levy wrote: > On Wed, Feb 22, 2012 at 11:17:17AM -0200, Luiz Capitulino wrote: > > On Tue, 21 Feb 2012 19:40:16 +0200 > > Alon Levy wrote: > > > > > On Tue, Feb 21, 2012 at 09:15:45AM -0700, Eric Blake wrote: > > > > On 02/21/2012 01:19 AM, Alon Levy wrot

Re: [Qemu-devel] [RFC 5/7] qxl-render: call ppm_save on callback

2012-02-22 Thread Alon Levy
On Wed, Feb 22, 2012 at 11:17:17AM -0200, Luiz Capitulino wrote: > On Tue, 21 Feb 2012 19:40:16 +0200 > Alon Levy wrote: > > > On Tue, Feb 21, 2012 at 09:15:45AM -0700, Eric Blake wrote: > > > On 02/21/2012 01:19 AM, Alon Levy wrote: > > > > > > >>> (2) Async monitor command. Keeps interface a

Re: [Qemu-devel] [RFC 5/7] qxl-render: call ppm_save on callback

2012-02-22 Thread Luiz Capitulino
On Tue, 21 Feb 2012 19:40:16 +0200 Alon Levy wrote: > On Tue, Feb 21, 2012 at 09:15:45AM -0700, Eric Blake wrote: > > On 02/21/2012 01:19 AM, Alon Levy wrote: > > > > >>> (2) Async monitor command. Keeps interface and works nicely. A bunch > > >>> of QAPI bits tickled into master meanwhi

Re: [Qemu-devel] [RFC 5/7] qxl-render: call ppm_save on callback

2012-02-21 Thread Alon Levy
On Tue, Feb 21, 2012 at 09:15:45AM -0700, Eric Blake wrote: > On 02/21/2012 01:19 AM, Alon Levy wrote: > > >>> (2) Async monitor command. Keeps interface and works nicely. A bunch > >>> of QAPI bits tickled into master meanwhile, so we could look at > >>> this again. Luiz? What is t

Re: [Qemu-devel] [RFC 5/7] qxl-render: call ppm_save on callback

2012-02-21 Thread Eric Blake
On 02/21/2012 01:19 AM, Alon Levy wrote: >>> (2) Async monitor command. Keeps interface and works nicely. A bunch >>> of QAPI bits tickled into master meanwhile, so we could look at >>> this again. Luiz? What is the status here? >>> >>> (3) Something like this patch + additionally

Re: [Qemu-devel] [RFC 5/7] qxl-render: call ppm_save on callback

2012-02-21 Thread Alon Levy
On Mon, Feb 20, 2012 at 02:29:11PM -0700, Eric Blake wrote: > On 02/20/2012 04:32 AM, Gerd Hoffmann wrote: > > Hmm, that is pretty lame. There are users like autotest which expect > > the screen dump being there when the monitor command is finished, that > > change will break them. > > Libvirt is

Re: [Qemu-devel] [RFC 5/7] qxl-render: call ppm_save on callback

2012-02-20 Thread Eric Blake
On 02/20/2012 04:32 AM, Gerd Hoffmann wrote: > Hmm, that is pretty lame. There are users like autotest which expect > the screen dump being there when the monitor command is finished, that > change will break them. Libvirt is another such user. > > Unfortunaly there is no easy way out. I think

Re: [Qemu-devel] [RFC 5/7] qxl-render: call ppm_save on callback

2012-02-20 Thread Gerd Hoffmann
Hi, >> (2) Async monitor command. Keeps interface and works nicely. A bunch >> of QAPI bits tickled into master meanwhile, so we could look at >> this again. Luiz? What is the status here? > > I was going to look for QAPI bits after this series (i.e. (2)). Doing > (3) is also pos

Re: [Qemu-devel] [RFC 5/7] qxl-render: call ppm_save on callback

2012-02-20 Thread Alon Levy
On Mon, Feb 20, 2012 at 12:32:44PM +0100, Gerd Hoffmann wrote: > On 02/19/12 22:28, Alon Levy wrote: > > This changes the behavior of the monitor command. After the previous > > patch, there is no longer an option of deadlock with virt-manager, but > > ppm_save is called too early, before the updat

Re: [Qemu-devel] [RFC 5/7] qxl-render: call ppm_save on callback

2012-02-20 Thread Gerd Hoffmann
On 02/19/12 22:28, Alon Levy wrote: > This changes the behavior of the monitor command. After the previous > patch, there is no longer an option of deadlock with virt-manager, but > ppm_save is called too early, before the update has completed. With this > patch it is called at the correct moment,

[Qemu-devel] [RFC 5/7] qxl-render: call ppm_save on callback

2012-02-19 Thread Alon Levy
This changes the behavior of the monitor command. After the previous patch, there is no longer an option of deadlock with virt-manager, but ppm_save is called too early, before the update has completed. With this patch it is called at the correct moment, but that means there is a race between the m