Re: [Qemu-devel] [RFC PATCH] Fix pasting into serial console in GTK ui

2017-01-03 Thread Gerd Hoffmann
Hi, > How do you propose to use that callback? I did not find a > documentation for it. It takes no argument (except the chr object self) > so there is no way to pass in the buffer. It cannot be replaced - > it is set in non-ui code in multiple places and never in ui code. No docs, but see back

Re: [Qemu-devel] [RFC PATCH] Fix pasting into serial console in GTK ui

2017-01-02 Thread Michal Suchánek
Hello, On Fri, 23 Dec 2016 17:29:28 +0100 Paolo Bonzini wrote: > On 23/12/2016 16:12, Michal Suchanek wrote: > > This copies the timer hack from ui/console.c kbd_send_chars to > > ui/gtk.c gd_vc_in. > > > > There is no fd-like object to peek repatedly so the paste data is > > saved in a free-fl

Re: [Qemu-devel] [RFC PATCH] Fix pasting into serial console in GTK ui

2016-12-23 Thread Paolo Bonzini
On 23/12/2016 16:12, Michal Suchanek wrote: > This copies the timer hack from ui/console.c kbd_send_chars to ui/gtk.c > gd_vc_in. > > There is no fd-like object to peek repatedly so the paste data is saved > in a free-floating buffer only submitted to gtk_timeout_add. Multiple > pastes can poten

[Qemu-devel] [RFC PATCH] Fix pasting into serial console in GTK ui

2016-12-23 Thread Michal Suchanek
This copies the timer hack from ui/console.c kbd_send_chars to ui/gtk.c gd_vc_in. There is no fd-like object to peek repatedly so the paste data is saved in a free-floating buffer only submitted to gtk_timeout_add. Multiple pastes can potentially interleave if qemu blocks for long or the user past

Re: [Qemu-devel] [RFC PATCH] Fix pasting into serial console in GTK ui

2016-12-23 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20161223151253.21338-1-msucha...@suse.de Subject: [Qemu-devel] [RFC PATCH] Fix pasting into serial console in GTK ui === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

[Qemu-devel] [RFC PATCH] Fix pasting into serial console in GTK ui

2016-12-23 Thread Michal Suchanek
This copies the timer hack from ui/console.c kbd_send_chars to ui/gtk.c gd_vc_in. There is no fd-like object to peek repatedly so the paste data is saved in a free-floating buffer only submitted to gtk_timeout_add. Multiple pastes can potentially interleave if qemu blocks for long or the user past