Re: [Qemu-devel] [RFC PATCH] NUMA: Enable adding NUMA node implicitly

2017-09-21 Thread Dou Liyang
Hi Igor, At 09/21/2017 03:54 PM, Igor Mammedov wrote: On Thu, 21 Sep 2017 12:19:17 +0800 [...] I've meant something like that: parse_numa_opts() { if (mc->auto_enable_numa_with_memhp == true) { qemu_opts_parse_noisily(qemu_find_opts("numa"), "node", true); } } Oops, Unde

Re: [Qemu-devel] [RFC PATCH] NUMA: Enable adding NUMA node implicitly

2017-09-21 Thread Igor Mammedov
On Thu, 21 Sep 2017 12:19:17 +0800 Dou Liyang wrote: > Hi Igor, > > I am sorry I missed some comments you gave to me. > > my reply is below. > At 09/18/2017 05:24 PM, Dou Liyang wrote: > [...] > >>> ranges where > >>> *the guest will attempt to probe for a device that QEMU doesn't > >>>

Re: [Qemu-devel] [RFC PATCH] NUMA: Enable adding NUMA node implicitly

2017-09-20 Thread Dou Liyang
Hi Igor, I am sorry I missed some comments you gave to me. my reply is below. At 09/18/2017 05:24 PM, Dou Liyang wrote: [...] ranges where *the guest will attempt to probe for a device that QEMU doesn't *implement and a stub device is required. + * @numa_implicit_add_node0: + *E

Re: [Qemu-devel] [RFC PATCH] NUMA: Enable adding NUMA node implicitly

2017-09-18 Thread Dou Liyang
Hi Igor, At 09/18/2017 05:08 PM, Igor Mammedov wrote: On Fri, 15 Sep 2017 16:33:18 +0800 Dou Liyang wrote: In QEMU, if we enable NUMA and have nodes, QEMU will build ACPI SRAT table for transfering NUMA configuration to the guest. So, the maximum memory in SRAT can be used to determine whethe

Re: [Qemu-devel] [RFC PATCH] NUMA: Enable adding NUMA node implicitly

2017-09-18 Thread Igor Mammedov
On Fri, 15 Sep 2017 16:33:18 +0800 Dou Liyang wrote: > In QEMU, if we enable NUMA and have nodes, QEMU will build ACPI SRAT table > for transfering NUMA configuration to the guest. So, the maximum memory in > SRAT can be used to determine whether to use the swiotlb for IOMMU or not. > However, if

Re: [Qemu-devel] [RFC PATCH] NUMA: Enable adding NUMA node implicitly

2017-09-18 Thread Dou Liyang
At 09/18/2017 03:40 PM, Igor Mammedov wrote: On Mon, 18 Sep 2017 11:54:50 +0800 Dou Liyang wrote: At 09/15/2017 06:05 PM, Dou Liyang wrote: Hi Daniel, At 09/15/2017 04:40 PM, Daniel P. Berrange wrote: On Fri, Sep 15, 2017 at 04:33:18PM +0800, Dou Liyang wrote: In QEMU, if we enable NUMA

Re: [Qemu-devel] [RFC PATCH] NUMA: Enable adding NUMA node implicitly

2017-09-18 Thread Igor Mammedov
On Mon, 18 Sep 2017 11:54:50 +0800 Dou Liyang wrote: > At 09/15/2017 06:05 PM, Dou Liyang wrote: > > Hi Daniel, > > > > At 09/15/2017 04:40 PM, Daniel P. Berrange wrote: > >> On Fri, Sep 15, 2017 at 04:33:18PM +0800, Dou Liyang wrote: > >>> In QEMU, if we enable NUMA and have nodes, QEMU will

Re: [Qemu-devel] [RFC PATCH] NUMA: Enable adding NUMA node implicitly

2017-09-17 Thread Dou Liyang
At 09/15/2017 06:05 PM, Dou Liyang wrote: Hi Daniel, At 09/15/2017 04:40 PM, Daniel P. Berrange wrote: On Fri, Sep 15, 2017 at 04:33:18PM +0800, Dou Liyang wrote: In QEMU, if we enable NUMA and have nodes, QEMU will build ACPI SRAT table for transfering NUMA configuration to the guest. So, the

Re: [Qemu-devel] [RFC PATCH] NUMA: Enable adding NUMA node implicitly

2017-09-15 Thread Dou Liyang
Hi Daniel, At 09/15/2017 04:40 PM, Daniel P. Berrange wrote: On Fri, Sep 15, 2017 at 04:33:18PM +0800, Dou Liyang wrote: In QEMU, if we enable NUMA and have nodes, QEMU will build ACPI SRAT table for transfering NUMA configuration to the guest. So, the maximum memory in SRAT can be used to dete

Re: [Qemu-devel] [RFC PATCH] NUMA: Enable adding NUMA node implicitly

2017-09-15 Thread Daniel P. Berrange
On Fri, Sep 15, 2017 at 04:33:18PM +0800, Dou Liyang wrote: > In QEMU, if we enable NUMA and have nodes, QEMU will build ACPI SRAT table > for transfering NUMA configuration to the guest. So, the maximum memory in > SRAT can be used to determine whether to use the swiotlb for IOMMU or not. > > How

[Qemu-devel] [RFC PATCH] NUMA: Enable adding NUMA node implicitly

2017-09-15 Thread Dou Liyang
In QEMU, if we enable NUMA and have nodes, QEMU will build ACPI SRAT table for transfering NUMA configuration to the guest. So, the maximum memory in SRAT can be used to determine whether to use the swiotlb for IOMMU or not. However, if QEmu doesn't enable NUMA explicitly on CLI, The SRAT will nev