Re: [Qemu-devel] [RFC PATCH] libcacard: Fix bug detected with 'smatch'

2015-09-14 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > On Mon, Sep 14, 2015 at 2:11 PM, Markus Armbruster wrote: >> Stumbled over this while throwing out old mail. Copying Marc-André and >> Jeremy. >> > > Thanks, the patch is applied in my libcacard "next" branch > (https://github.com/elmarco/libcacard/tree/next).

Re: [Qemu-devel] [RFC PATCH] libcacard: Fix bug detected with 'smatch'

2015-09-14 Thread Marc-André Lureau
Hi On Mon, Sep 14, 2015 at 2:11 PM, Markus Armbruster wrote: > Stumbled over this while throwing out old mail. Copying Marc-André and > Jeremy. > Thanks, the patch is applied in my libcacard "next" branch (https://github.com/elmarco/libcacard/tree/next). > Thomas Huth writes: > >> 'smatch' co

Re: [Qemu-devel] [RFC PATCH] libcacard: Fix bug detected with 'smatch'

2015-09-14 Thread Markus Armbruster
Stumbled over this while throwing out old mail. Copying Marc-André and Jeremy. Thomas Huth writes: > 'smatch' complains about two bugs and one style issue in card_7816.c: > > libcacard/card_7816.c:273 vcard_apdu_set_length() warn: should this be a > bitwise op? > libcacard/card_7816.c:295 vcar

[Qemu-devel] [RFC PATCH] libcacard: Fix bug detected with 'smatch'

2015-03-19 Thread Thomas Huth
'smatch' complains about two bugs and one style issue in card_7816.c: libcacard/card_7816.c:273 vcard_apdu_set_length() warn: should this be a bitwise op? libcacard/card_7816.c:295 vcard_apdu_set_length() warn: should this be a bitwise op? libcacard/card_7816.c:661 vcard7816_vm_process_apdu() wa