Re: [Qemu-devel] [RFC PATCH] target/arm: Fix int128_make128 lo, hi order in paired_cmpxchg64_be

2019-02-14 Thread Peter Maydell
On Mon, 11 Feb 2019 at 16:49, Richard Henderson wrote: > > On 2/11/19 8:19 AM, Peter Maydell wrote: > > Thanks. Richard: is this effectively a bugfix for big-endian guest code ? > > Yes. Thanks, applied to target-arm.next; I've added a line to the commit message to note that it only affects BE gu

Re: [Qemu-devel] [RFC PATCH] target/arm: Fix int128_make128 lo, hi order in paired_cmpxchg64_be

2019-02-11 Thread Richard Henderson
On 2/11/19 8:19 AM, Peter Maydell wrote: > Thanks. Richard: is this effectively a bugfix for big-endian guest code ? Yes. r~

Re: [Qemu-devel] [RFC PATCH] target/arm: Fix int128_make128 lo, hi order in paired_cmpxchg64_be

2019-02-11 Thread Richard Henderson
On 1/31/19 5:40 PM, Catherine Ho wrote: > The lo,hi order is different from the comments. And in commit > 1ec182c33379 ("target/arm: Convert to HAVE_CMPXCHG128"), it changes > the original code logic. So just restore the old code logic before this > commit: > do_paired_cmpxchg64_be(): > cmpv =

Re: [Qemu-devel] [RFC PATCH] target/arm: Fix int128_make128 lo, hi order in paired_cmpxchg64_be

2019-02-11 Thread Peter Maydell
On Mon, 11 Feb 2019 at 16:11, Richard Henderson wrote: > > On 1/31/19 5:40 PM, Catherine Ho wrote: > > The lo,hi order is different from the comments. And in commit > > 1ec182c33379 ("target/arm: Convert to HAVE_CMPXCHG128"), it changes > > the original code logic. So just restore the old code log

[Qemu-devel] [RFC PATCH] target/arm: Fix int128_make128 lo, hi order in paired_cmpxchg64_be

2019-01-31 Thread Catherine Ho
The lo,hi order is different from the comments. And in commit 1ec182c33379 ("target/arm: Convert to HAVE_CMPXCHG128"), it changes the original code logic. So just restore the old code logic before this commit: do_paired_cmpxchg64_be(): cmpv = int128_make128(env->exclusive_high, env->exclusive_