Re: [Qemu-devel] [RFC PATCH] target-arm/psci.c: wake up sleeping CPUs (MTTCG)

2015-06-26 Thread Andrew Jones
On Fri, Jun 26, 2015 at 08:06:55AM +0100, Alex Bennée wrote: > > Andrew Jones writes: > > > On Wed, Jun 24, 2015 at 08:12:52PM +0100, Peter Maydell wrote: > >> On 24 June 2015 at 18:18, Alex Bennée wrote: > >> > > >> > Paolo Bonzini writes: > >> > > >> >> On 24/06/2015 17:34, Alex Bennée wrote

Re: [Qemu-devel] [RFC PATCH] target-arm/psci.c: wake up sleeping CPUs (MTTCG)

2015-06-26 Thread Alex Bennée
Andrew Jones writes: > On Wed, Jun 24, 2015 at 08:12:52PM +0100, Peter Maydell wrote: >> On 24 June 2015 at 18:18, Alex Bennée wrote: >> > >> > Paolo Bonzini writes: >> > >> >> On 24/06/2015 17:34, Alex Bennée wrote: >> >>> Testing with Alexander's bare metal syncronisation tests fails in MTTC

Re: [Qemu-devel] [RFC PATCH] target-arm/psci.c: wake up sleeping CPUs (MTTCG)

2015-06-25 Thread Andrew Jones
On Wed, Jun 24, 2015 at 08:12:52PM +0100, Peter Maydell wrote: > On 24 June 2015 at 18:18, Alex Bennée wrote: > > > > Paolo Bonzini writes: > > > >> On 24/06/2015 17:34, Alex Bennée wrote: > >>> Testing with Alexander's bare metal syncronisation tests fails in MTTCG > >>> leaving one CPU spinning

Re: [Qemu-devel] [RFC PATCH] target-arm/psci.c: wake up sleeping CPUs (MTTCG)

2015-06-25 Thread Frederic Konrad
On 25/06/2015 01:55, Alexander Spyridakis wrote: On 24 June 2015 at 17:34, Alex Bennée wrote: Testing with Alexander's bare metal syncronisation tests fails in MTTCG leaving one CPU spinning forever waiting for the second CPU to wake up. We simply need to poke the halt_cond once we have process

Re: [Qemu-devel] [RFC PATCH] target-arm/psci.c: wake up sleeping CPUs (MTTCG)

2015-06-24 Thread Alex Bennée
Alexander Spyridakis writes: > On 24 June 2015 at 17:34, Alex Bennée wrote: >> Testing with Alexander's bare metal syncronisation tests fails in MTTCG >> leaving one CPU spinning forever waiting for the second CPU to wake up. >> We simply need to poke the halt_cond once we have processed the PS

Re: [Qemu-devel] [RFC PATCH] target-arm/psci.c: wake up sleeping CPUs (MTTCG)

2015-06-24 Thread Alexander Spyridakis
On 24 June 2015 at 17:34, Alex Bennée wrote: > Testing with Alexander's bare metal syncronisation tests fails in MTTCG > leaving one CPU spinning forever waiting for the second CPU to wake up. > We simply need to poke the halt_cond once we have processed the PSCI > power on call. Thanks Alex. Wor

Re: [Qemu-devel] [RFC PATCH] target-arm/psci.c: wake up sleeping CPUs (MTTCG)

2015-06-24 Thread Peter Maydell
On 24 June 2015 at 18:18, Alex Bennée wrote: > > Paolo Bonzini writes: > >> On 24/06/2015 17:34, Alex Bennée wrote: >>> Testing with Alexander's bare metal syncronisation tests fails in MTTCG >>> leaving one CPU spinning forever waiting for the second CPU to wake up. >>> We simply need to poke th

Re: [Qemu-devel] [RFC PATCH] target-arm/psci.c: wake up sleeping CPUs (MTTCG)

2015-06-24 Thread Alex Bennée
Paolo Bonzini writes: > On 24/06/2015 19:18, Alex Bennée wrote: >> @@ -196,6 +196,8 @@ void arm_handle_psci_call(ARMCPU *cpu) >> } >> target_cpu_class->set_pc(target_cpu_state, entry); >> >> +qemu_cond_signal(target_cpu_state->halt_cond); >>>

Re: [Qemu-devel] [RFC PATCH] target-arm/psci.c: wake up sleeping CPUs (MTTCG)

2015-06-24 Thread Paolo Bonzini
On 24/06/2015 19:18, Alex Bennée wrote: >>> >> @@ -196,6 +196,8 @@ void arm_handle_psci_call(ARMCPU *cpu) >>> >> } >>> >> target_cpu_class->set_pc(target_cpu_state, entry); >>> >> >>> >> +qemu_cond_signal(target_cpu_state->halt_cond); >> > >> > That's called qemu_cpu_k

Re: [Qemu-devel] [RFC PATCH] target-arm/psci.c: wake up sleeping CPUs (MTTCG)

2015-06-24 Thread Alex Bennée
Paolo Bonzini writes: > On 24/06/2015 17:34, Alex Bennée wrote: >> Testing with Alexander's bare metal syncronisation tests fails in MTTCG >> leaving one CPU spinning forever waiting for the second CPU to wake up. >> We simply need to poke the halt_cond once we have processed the PSCI >> power o

Re: [Qemu-devel] [RFC PATCH] target-arm/psci.c: wake up sleeping CPUs (MTTCG)

2015-06-24 Thread Paolo Bonzini
On 24/06/2015 17:34, Alex Bennée wrote: > Testing with Alexander's bare metal syncronisation tests fails in MTTCG > leaving one CPU spinning forever waiting for the second CPU to wake up. > We simply need to poke the halt_cond once we have processed the PSCI > power on call. > > Tested-by: Alex

[Qemu-devel] [RFC PATCH] target-arm/psci.c: wake up sleeping CPUs (MTTCG)

2015-06-24 Thread Alex Bennée
Testing with Alexander's bare metal syncronisation tests fails in MTTCG leaving one CPU spinning forever waiting for the second CPU to wake up. We simply need to poke the halt_cond once we have processed the PSCI power on call. Tested-by: Alex Bennée CC: Alexander Spyridakis --- TODO - exactl