Re: [Qemu-devel] [RFC PATCH 0/3] tweaks for QEMU's C standard

2018-08-13 Thread Daniel P . Berrangé
On Mon, Aug 13, 2018 at 11:25:49AM +0200, Thomas Huth wrote: > On 08/13/2018 11:07 AM, Daniel P. Berrangé wrote: > > On Fri, Aug 10, 2018 at 06:10:58PM +0100, Alex Bennée wrote: > >> Hi, > >> > >> While I was reviewing Richard's SVE series I found Travis choking on > >> some perfectly valid c99. It

Re: [Qemu-devel] [RFC PATCH 0/3] tweaks for QEMU's C standard

2018-08-13 Thread Alex Bennée
Daniel P. Berrangé writes: > On Mon, Aug 13, 2018 at 10:07:05AM +0100, Daniel P. Berrangé wrote: >> On Fri, Aug 10, 2018 at 06:10:58PM +0100, Alex Bennée wrote: >> > Hi, >> > >> > While I was reviewing Richard's SVE series I found Travis choking on >> > some perfectly valid c99. It turns out th

Re: [Qemu-devel] [RFC PATCH 0/3] tweaks for QEMU's C standard

2018-08-13 Thread Peter Maydell
On 13 August 2018 at 10:18, Daniel P. Berrangé wrote: > Also, we should ensure the min required GCC version via biuld time > check of some kind. eg something like > > #if !(__GNUC_PREREQ(4, 4) || defined(__clang__)) > # error "QEMU requires GCC >= 4.4, or CLang" > #endif Our current minimum is 4.

Re: [Qemu-devel] [RFC PATCH 0/3] tweaks for QEMU's C standard

2018-08-13 Thread Thomas Huth
On 08/13/2018 11:07 AM, Daniel P. Berrangé wrote: > On Fri, Aug 10, 2018 at 06:10:58PM +0100, Alex Bennée wrote: >> Hi, >> >> While I was reviewing Richard's SVE series I found Travis choking on >> some perfectly valid c99. It turns out that Travis default image is >> old enough that gcc defaults t

Re: [Qemu-devel] [RFC PATCH 0/3] tweaks for QEMU's C standard

2018-08-13 Thread Daniel P . Berrangé
On Mon, Aug 13, 2018 at 10:07:05AM +0100, Daniel P. Berrangé wrote: > On Fri, Aug 10, 2018 at 06:10:58PM +0100, Alex Bennée wrote: > > Hi, > > > > While I was reviewing Richard's SVE series I found Travis choking on > > some perfectly valid c99. It turns out that Travis default image is > > old en

Re: [Qemu-devel] [RFC PATCH 0/3] tweaks for QEMU's C standard

2018-08-13 Thread Daniel P . Berrangé
On Fri, Aug 10, 2018 at 06:10:58PM +0100, Alex Bennée wrote: > Hi, > > While I was reviewing Richard's SVE series I found Travis choking on > some perfectly valid c99. It turns out that Travis default image is > old enough that gcc defaults to -std=gnu89 hence the problem. However > switching to c

[Qemu-devel] [RFC PATCH 0/3] tweaks for QEMU's C standard

2018-08-10 Thread Alex Bennée
Hi, While I was reviewing Richard's SVE series I found Travis choking on some perfectly valid c99. It turns out that Travis default image is old enough that gcc defaults to -std=gnu89 hence the problem. However switching to c99 isn't enough as we use GNUisms and even gnu99 still trips up on qemu-s