Re: [Qemu-devel] [RFC PATCH 0/2] Acceptance tests for qemu-img

2018-11-13 Thread Kevin Wolf
Hi Cleber, I will shorten this email a lot while replying because I have the impression that most of the discussion isn't actually as productive as it could be. I'm not trying to evade on any point that I'm cutting out, so if there is something specific in the part I'm removing that you would like

Re: [Qemu-devel] [RFC PATCH 0/2] Acceptance tests for qemu-img

2018-11-13 Thread Eduardo Habkost
On Tue, Nov 13, 2018 at 09:43:49AM -0500, Cleber Rosa wrote: > > On 11/13/18 9:32 AM, Eduardo Habkost wrote: > > On Tue, Nov 13, 2018 at 09:20:11AM -0500, Cleber Rosa wrote: > > > > With check-venv, we made "installing avocado" a small > > implementation detail that people don't need to care abou

Re: [Qemu-devel] [RFC PATCH 0/2] Acceptance tests for qemu-img

2018-11-13 Thread Cleber Rosa
On 11/13/18 9:32 AM, Eduardo Habkost wrote: > On Tue, Nov 13, 2018 at 09:20:11AM -0500, Cleber Rosa wrote: > > With check-venv, we made "installing avocado" a small > implementation detail that people don't need to care about when > running the tests. > > I believe the sentence "which must be i

Re: [Qemu-devel] [RFC PATCH 0/2] Acceptance tests for qemu-img

2018-11-13 Thread Cleber Rosa
On 11/13/18 8:50 AM, Daniel P. Berrangé wrote: > On Tue, Nov 13, 2018 at 10:39:57AM +0100, Markus Armbruster wrote: >> Drive-by comment... >> >> Cleber Rosa writes: >> >> [...] >>> My impression is that the "infrastructure for block tests" is not that >>> different from the infrastructure neede

Re: [Qemu-devel] [RFC PATCH 0/2] Acceptance tests for qemu-img

2018-11-13 Thread Eduardo Habkost
On Tue, Nov 13, 2018 at 09:20:11AM -0500, Cleber Rosa wrote: > > > On 11/13/18 8:51 AM, Kevin Wolf wrote: > > Am 13.11.2018 um 14:26 hat Eduardo Habkost geschrieben: > >> On Tue, Nov 13, 2018 at 01:18:36PM +0100, Kevin Wolf wrote: > >> [...] > >>> Anyway, one specific concern about the "simple wa

Re: [Qemu-devel] [RFC PATCH 0/2] Acceptance tests for qemu-img

2018-11-13 Thread Cleber Rosa
On 11/13/18 8:51 AM, Kevin Wolf wrote: > Am 13.11.2018 um 14:26 hat Eduardo Habkost geschrieben: >> On Tue, Nov 13, 2018 at 01:18:36PM +0100, Kevin Wolf wrote: >> [...] >>> Anyway, one specific concern about the "simple way" I have is that we're >>> adding a hard dependency on an external packag

Re: [Qemu-devel] [RFC PATCH 0/2] Acceptance tests for qemu-img

2018-11-13 Thread Cleber Rosa
On 11/13/18 7:18 AM, Kevin Wolf wrote: > Am 12.11.2018 um 18:36 hat Cleber Rosa geschrieben: >> I hope you don't blame me for trying to have the advantage of the >> counter answer. :) > > Thanks for being so honest, but do you actually need this advantage when > you have good technical arguments

Re: [Qemu-devel] [RFC PATCH 0/2] Acceptance tests for qemu-img

2018-11-13 Thread Eduardo Habkost
On Tue, Nov 13, 2018 at 02:51:16PM +0100, Kevin Wolf wrote: > Am 13.11.2018 um 14:26 hat Eduardo Habkost geschrieben: > > On Tue, Nov 13, 2018 at 01:18:36PM +0100, Kevin Wolf wrote: > > [...] > > > Anyway, one specific concern about the "simple way" I have is that we're > > > adding a hard dependen

Re: [Qemu-devel] [RFC PATCH 0/2] Acceptance tests for qemu-img

2018-11-13 Thread Kevin Wolf
Am 13.11.2018 um 14:26 hat Eduardo Habkost geschrieben: > On Tue, Nov 13, 2018 at 01:18:36PM +0100, Kevin Wolf wrote: > [...] > > Anyway, one specific concern about the "simple way" I have is that we're > > adding a hard dependency on an external package (Avocado) that isn't > > usually installed a

Re: [Qemu-devel] [RFC PATCH 0/2] Acceptance tests for qemu-img

2018-11-13 Thread Daniel P . Berrangé
On Tue, Nov 13, 2018 at 10:39:57AM +0100, Markus Armbruster wrote: > Drive-by comment... > > Cleber Rosa writes: > > [...] > > My impression is that the "infrastructure for block tests" is not that > > different from the infrastructure needed by other tests, specially other > > QEMU tests. > [..

Re: [Qemu-devel] [RFC PATCH 0/2] Acceptance tests for qemu-img

2018-11-13 Thread Eduardo Habkost
On Tue, Nov 13, 2018 at 01:18:36PM +0100, Kevin Wolf wrote: [...] > Anyway, one specific concern about the "simple way" I have is that we're > adding a hard dependency on an external package (Avocado) that isn't > usually installed anyway on developer machines. Maintainers will of > course just ins

Re: [Qemu-devel] [RFC PATCH 0/2] Acceptance tests for qemu-img

2018-11-13 Thread Kevin Wolf
Am 12.11.2018 um 18:36 hat Cleber Rosa geschrieben: > I hope you don't blame me for trying to have the advantage of the > counter answer. :) Thanks for being so honest, but do you actually need this advantage when you have good technical arguments in favour of your proposal? > >> And run all test

Re: [Qemu-devel] [RFC PATCH 0/2] Acceptance tests for qemu-img

2018-11-13 Thread Markus Armbruster
Drive-by comment... Cleber Rosa writes: [...] > My impression is that the "infrastructure for block tests" is not that > different from the infrastructure needed by other tests, specially other > QEMU tests. [...] Yes. The actual reason for having a completely separate testing infrastructure f

Re: [Qemu-devel] [RFC PATCH 0/2] Acceptance tests for qemu-img

2018-11-12 Thread Cleber Rosa
On 11/12/18 11:00 AM, Kevin Wolf wrote: > Am 12.11.2018 um 15:59 hat Cleber Rosa geschrieben: >> >> On 11/12/18 5:49 AM, Kevin Wolf wrote: >>> Am 09.11.2018 um 23:12 hat Cleber Rosa geschrieben: The initial goal of this RFC is to get feedback on tests not specific to the QEMU main bina

Re: [Qemu-devel] [RFC PATCH 0/2] Acceptance tests for qemu-img

2018-11-12 Thread Kevin Wolf
Am 12.11.2018 um 15:59 hat Cleber Rosa geschrieben: > > On 11/12/18 5:49 AM, Kevin Wolf wrote: > > Am 09.11.2018 um 23:12 hat Cleber Rosa geschrieben: > >> The initial goal of this RFC is to get feedback on tests not specific > >> to the QEMU main binary, but specific to other components such as >

Re: [Qemu-devel] [RFC PATCH 0/2] Acceptance tests for qemu-img

2018-11-12 Thread Daniel P . Berrangé
On Mon, Nov 12, 2018 at 09:59:56AM -0500, Cleber Rosa wrote: > > On 11/12/18 5:49 AM, Kevin Wolf wrote: > > Am 09.11.2018 um 23:12 hat Cleber Rosa geschrieben: > >> The initial goal of this RFC is to get feedback on tests not specific > >> to the QEMU main binary, but specific to other components

Re: [Qemu-devel] [RFC PATCH 0/2] Acceptance tests for qemu-img

2018-11-12 Thread Cleber Rosa
On 11/12/18 5:49 AM, Kevin Wolf wrote: > Am 09.11.2018 um 23:12 hat Cleber Rosa geschrieben: >> The initial goal of this RFC is to get feedback on tests not specific >> to the QEMU main binary, but specific to other components such as >> qemu-img. >> >> For this experiment, a small issue with the

Re: [Qemu-devel] [RFC PATCH 0/2] Acceptance tests for qemu-img

2018-11-12 Thread Kevin Wolf
Am 09.11.2018 um 23:12 hat Cleber Rosa geschrieben: > The initial goal of this RFC is to get feedback on tests not specific > to the QEMU main binary, but specific to other components such as > qemu-img. > > For this experiment, a small issue with the zero and negative number > of I/O operations g

[Qemu-devel] [RFC PATCH 0/2] Acceptance tests for qemu-img

2018-11-09 Thread Cleber Rosa
The initial goal of this RFC is to get feedback on tests not specific to the QEMU main binary, but specific to other components such as qemu-img. For this experiment, a small issue with the zero and negative number of I/O operations given to the bench command was chosen. Cleber Rosa (2): Accept