Re: [Qemu-devel] [RFC PATCH 0/4] nvdimm: enable flush hint address structure

2017-04-21 Thread Dan Williams
[ adding xfs and fsdevel ] On Fri, Apr 21, 2017 at 6:56 AM, Stefan Hajnoczi wrote: [..] >> >>> If the vNVDIMM device is based on the regular file, i think >> >>> fsync is the bottleneck rather than this mmio-virtualization. :( >> >>> >> >> >> >> Yes, fsync() on the regular

Re: [Qemu-devel] [RFC PATCH 0/4] nvdimm: enable flush hint address structure

2017-04-21 Thread Stefan Hajnoczi
On Thu, Apr 20, 2017 at 12:49:21PM -0700, Dan Williams wrote: > On Tue, Apr 11, 2017 at 7:56 AM, Dan Williams > wrote: > > [ adding Christoph ] > > > > On Tue, Apr 11, 2017 at 1:41 AM, Haozhong Zhang > > wrote: > >> On 04/06/17 20:02 +0800,

Re: [Qemu-devel] [RFC PATCH 0/4] nvdimm: enable flush hint address structure

2017-04-20 Thread Dan Williams
On Tue, Apr 11, 2017 at 7:56 AM, Dan Williams wrote: > [ adding Christoph ] > > On Tue, Apr 11, 2017 at 1:41 AM, Haozhong Zhang > wrote: >> On 04/06/17 20:02 +0800, Xiao Guangrong wrote: >>> >>> >>> On 04/06/2017 05:43 PM, Stefan Hajnoczi

Re: [Qemu-devel] [RFC PATCH 0/4] nvdimm: enable flush hint address structure

2017-04-18 Thread Stefan Hajnoczi
On Tue, Apr 11, 2017 at 02:34:26PM +0800, Haozhong Zhang wrote: > On 04/06/17 10:43 +0100, Stefan Hajnoczi wrote: > > On Fri, Mar 31, 2017 at 04:41:43PM +0800, Haozhong Zhang wrote: > > > This patch series constructs the flush hint address structures for > > > nvdimm devices in QEMU. > > > > > >

Re: [Qemu-devel] [RFC PATCH 0/4] nvdimm: enable flush hint address structure

2017-04-11 Thread Dan Williams
[ adding Christoph ] On Tue, Apr 11, 2017 at 1:41 AM, Haozhong Zhang wrote: > On 04/06/17 20:02 +0800, Xiao Guangrong wrote: >> >> >> On 04/06/2017 05:43 PM, Stefan Hajnoczi wrote: >> > On Fri, Mar 31, 2017 at 04:41:43PM +0800, Haozhong Zhang wrote: >> > > This patch

Re: [Qemu-devel] [RFC PATCH 0/4] nvdimm: enable flush hint address structure

2017-04-11 Thread Haozhong Zhang
On 04/06/17 20:02 +0800, Xiao Guangrong wrote: > > > On 04/06/2017 05:43 PM, Stefan Hajnoczi wrote: > > On Fri, Mar 31, 2017 at 04:41:43PM +0800, Haozhong Zhang wrote: > > > This patch series constructs the flush hint address structures for > > > nvdimm devices in QEMU. > > > > > > It's of

Re: [Qemu-devel] [RFC PATCH 0/4] nvdimm: enable flush hint address structure

2017-04-11 Thread Haozhong Zhang
On 04/06/17 10:43 +0100, Stefan Hajnoczi wrote: > On Fri, Mar 31, 2017 at 04:41:43PM +0800, Haozhong Zhang wrote: > > This patch series constructs the flush hint address structures for > > nvdimm devices in QEMU. > > > > It's of course not for 2.9. I send it out early in order to get > > comments

Re: [Qemu-devel] [RFC PATCH 0/4] nvdimm: enable flush hint address structure

2017-04-07 Thread Stefan Hajnoczi
On Thu, Apr 06, 2017 at 06:31:17PM +0800, Haozhong Zhang wrote: > On 04/06/17 10:43 +0100, Stefan Hajnoczi wrote: > > On Fri, Mar 31, 2017 at 04:41:43PM +0800, Haozhong Zhang wrote: > > We should think about the optimal way of implementing Flush Hint > > Addresses in QEMU. But if there is no

Re: [Qemu-devel] [RFC PATCH 0/4] nvdimm: enable flush hint address structure

2017-04-07 Thread Stefan Hajnoczi
On Thu, Apr 06, 2017 at 07:32:01AM -0700, Dan Williams wrote: > On Thu, Apr 6, 2017 at 2:43 AM, Stefan Hajnoczi wrote: > > On Fri, Mar 31, 2017 at 04:41:43PM +0800, Haozhong Zhang wrote: > * I don't think we can just skip implementing support for this flush. > Yes it's

Re: [Qemu-devel] [RFC PATCH 0/4] nvdimm: enable flush hint address structure

2017-04-06 Thread Xiao Guangrong
On 31/03/2017 4:41 PM, Haozhong Zhang wrote: This patch series constructs the flush hint address structures for nvdimm devices in QEMU. It's of course not for 2.9. I send it out early in order to get comments on one point I'm uncertain (see the detailed explanation below). Thanks for any

Re: [Qemu-devel] [RFC PATCH 0/4] nvdimm: enable flush hint address structure

2017-04-06 Thread Xiao Guangrong
On 04/06/2017 05:43 PM, Stefan Hajnoczi wrote: On Fri, Mar 31, 2017 at 04:41:43PM +0800, Haozhong Zhang wrote: This patch series constructs the flush hint address structures for nvdimm devices in QEMU. It's of course not for 2.9. I send it out early in order to get comments on one point I'm

Re: [Qemu-devel] [RFC PATCH 0/4] nvdimm: enable flush hint address structure

2017-04-06 Thread Xiao Guangrong
On 04/06/2017 05:58 PM, Haozhong Zhang wrote: On 04/06/17 17:39 +0800, Xiao Guangrong wrote: On 31/03/2017 4:41 PM, Haozhong Zhang wrote: This patch series constructs the flush hint address structures for nvdimm devices in QEMU. It's of course not for 2.9. I send it out early in order to

Re: [Qemu-devel] [RFC PATCH 0/4] nvdimm: enable flush hint address structure

2017-04-06 Thread Dan Williams
On Thu, Apr 6, 2017 at 2:43 AM, Stefan Hajnoczi wrote: > On Fri, Mar 31, 2017 at 04:41:43PM +0800, Haozhong Zhang wrote: >> This patch series constructs the flush hint address structures for >> nvdimm devices in QEMU. >> >> It's of course not for 2.9. I send it out early in

Re: [Qemu-devel] [RFC PATCH 0/4] nvdimm: enable flush hint address structure

2017-04-06 Thread Haozhong Zhang
On 04/06/17 10:43 +0100, Stefan Hajnoczi wrote: > On Fri, Mar 31, 2017 at 04:41:43PM +0800, Haozhong Zhang wrote: > > This patch series constructs the flush hint address structures for > > nvdimm devices in QEMU. > > > > It's of course not for 2.9. I send it out early in order to get > > comments

Re: [Qemu-devel] [RFC PATCH 0/4] nvdimm: enable flush hint address structure

2017-04-06 Thread Haozhong Zhang
On 04/06/17 17:39 +0800, Xiao Guangrong wrote: > > > On 31/03/2017 4:41 PM, Haozhong Zhang wrote: > > This patch series constructs the flush hint address structures for > > nvdimm devices in QEMU. > > > > It's of course not for 2.9. I send it out early in order to get > > comments on one point

Re: [Qemu-devel] [RFC PATCH 0/4] nvdimm: enable flush hint address structure

2017-04-06 Thread Stefan Hajnoczi
On Fri, Mar 31, 2017 at 04:41:43PM +0800, Haozhong Zhang wrote: > This patch series constructs the flush hint address structures for > nvdimm devices in QEMU. > > It's of course not for 2.9. I send it out early in order to get > comments on one point I'm uncertain (see the detailed explanation >

[Qemu-devel] [RFC PATCH 0/4] nvdimm: enable flush hint address structure

2017-03-31 Thread Haozhong Zhang
This patch series constructs the flush hint address structures for nvdimm devices in QEMU. It's of course not for 2.9. I send it out early in order to get comments on one point I'm uncertain (see the detailed explanation below). Thanks for any comments in advance! Background ---