Re: [Qemu-devel] [RFC PATCH 1/2] cpus-common: nuke finish_safe_work

2019-06-24 Thread Alex Bennée
Roman Kagan writes: > On Mon, Jun 24, 2019 at 11:58:23AM +0100, Alex Bennée wrote: >> Roman Kagan writes: >> >> > It was introduced in commit b129972c8b41e15b0521895a46fd9c752b68a5e, >> > with the following motivation: >> >> I can't find this commit in my tree. > > OOPS, that was supposed to b

Re: [Qemu-devel] [RFC PATCH 1/2] cpus-common: nuke finish_safe_work

2019-06-24 Thread Roman Kagan
On Mon, Jun 24, 2019 at 11:58:23AM +0100, Alex Bennée wrote: > Roman Kagan writes: > > > It was introduced in commit b129972c8b41e15b0521895a46fd9c752b68a5e, > > with the following motivation: > > I can't find this commit in my tree. OOPS, that was supposed to be ab129972c8b41e15b0521895a46fd9c

Re: [Qemu-devel] [RFC PATCH 1/2] cpus-common: nuke finish_safe_work

2019-06-24 Thread Alex Bennée
Roman Kagan writes: > It was introduced in commit b129972c8b41e15b0521895a46fd9c752b68a5e, > with the following motivation: I can't find this commit in my tree. > > Because start_exclusive uses CPU_FOREACH, merge exclusive_lock with > qemu_cpu_list_lock: together with a call to exclusive_

[Qemu-devel] [RFC PATCH 1/2] cpus-common: nuke finish_safe_work

2019-05-23 Thread Roman Kagan
It was introduced in commit b129972c8b41e15b0521895a46fd9c752b68a5e, with the following motivation: Because start_exclusive uses CPU_FOREACH, merge exclusive_lock with qemu_cpu_list_lock: together with a call to exclusive_idle (via cpu_exec_start/end) in cpu_list_add, this protects exclusive