Re: [Qemu-devel] [RFC PATCH 1/2] qemu-help: Sort devices by logical functionality

2013-07-21 Thread Ronen Hod
On 07/18/2013 05:28 PM, Anthony Liguori wrote: Marcel Apfelbaum writes: Categorize devices that appear as output to "-device ?" command by logical functionality. Sort the devices by logical categories before showing them to user. Signed-off-by: Marcel Apfelbaum Reviewed-by: Kevin Wolf ---

Re: [Qemu-devel] [RFC PATCH 1/2] qemu-help: Sort devices by logical functionality

2013-07-21 Thread Michael S. Tsirkin
On Thu, Jul 18, 2013 at 09:58:59AM -0500, Anthony Liguori wrote: > Paolo Bonzini writes: > > > Il 18/07/2013 16:42, Marcel Apfelbaum ha scritto: > >> On Thu, 2013-07-18 at 09:28 -0500, Anthony Liguori wrote: > >>> Marcel Apfelbaum writes: > >>> > Categorize devices that appear as output to

Re: [Qemu-devel] [RFC PATCH 1/2] qemu-help: Sort devices by logical functionality

2013-07-18 Thread Paolo Bonzini
Il 18/07/2013 17:23, Marcel Apfelbaum ha scritto: Antony, thanks for your review! The whole point was to find a way to differentiate them by functionality so they can be sorted... Is it possible that a multifunction pci card will be used for more then one category mentioned

Re: [Qemu-devel] [RFC PATCH 1/2] qemu-help: Sort devices by logical functionality

2013-07-18 Thread Marcel Apfelbaum
On Thu, 2013-07-18 at 09:58 -0500, Anthony Liguori wrote: > Paolo Bonzini writes: > > > Il 18/07/2013 16:42, Marcel Apfelbaum ha scritto: > >> On Thu, 2013-07-18 at 09:28 -0500, Anthony Liguori wrote: > >>> Marcel Apfelbaum writes: > >>> > Categorize devices that appear as output to "-devic

Re: [Qemu-devel] [RFC PATCH 1/2] qemu-help: Sort devices by logical functionality

2013-07-18 Thread Anthony Liguori
Paolo Bonzini writes: > Il 18/07/2013 16:42, Marcel Apfelbaum ha scritto: >> On Thu, 2013-07-18 at 09:28 -0500, Anthony Liguori wrote: >>> Marcel Apfelbaum writes: >>> Categorize devices that appear as output to "-device ?" command by logical functionality. Sort the devices by logical

Re: [Qemu-devel] [RFC PATCH 1/2] qemu-help: Sort devices by logical functionality

2013-07-18 Thread Paolo Bonzini
Il 18/07/2013 16:42, Marcel Apfelbaum ha scritto: > On Thu, 2013-07-18 at 09:28 -0500, Anthony Liguori wrote: >> Marcel Apfelbaum writes: >> >>> Categorize devices that appear as output to "-device ?" command >>> by logical functionality. Sort the devices by logical categories >>> before showing t

Re: [Qemu-devel] [RFC PATCH 1/2] qemu-help: Sort devices by logical functionality

2013-07-18 Thread Marcel Apfelbaum
On Thu, 2013-07-18 at 09:28 -0500, Anthony Liguori wrote: > Marcel Apfelbaum writes: > > > Categorize devices that appear as output to "-device ?" command > > by logical functionality. Sort the devices by logical categories > > before showing them to user. > > > > Signed-off-by: Marcel Apfelbaum

Re: [Qemu-devel] [RFC PATCH 1/2] qemu-help: Sort devices by logical functionality

2013-07-18 Thread Anthony Liguori
Marcel Apfelbaum writes: > Categorize devices that appear as output to "-device ?" command > by logical functionality. Sort the devices by logical categories > before showing them to user. > > Signed-off-by: Marcel Apfelbaum > Reviewed-by: Kevin Wolf > --- > include/hw/qdev-core.h | 7 +++

Re: [Qemu-devel] [RFC PATCH 1/2] qemu-help: Sort devices by logical functionality

2013-07-18 Thread Michael S. Tsirkin
On Thu, Jul 18, 2013 at 11:27:42AM +0300, Marcel Apfelbaum wrote: > Categorize devices that appear as output to "-device ?" command > by logical functionality. Sort the devices by logical categories > before showing them to user. > > Signed-off-by: Marcel Apfelbaum > Reviewed-by: Kevin Wolf > --

[Qemu-devel] [RFC PATCH 1/2] qemu-help: Sort devices by logical functionality

2013-07-18 Thread Marcel Apfelbaum
Categorize devices that appear as output to "-device ?" command by logical functionality. Sort the devices by logical categories before showing them to user. Signed-off-by: Marcel Apfelbaum Reviewed-by: Kevin Wolf --- include/hw/qdev-core.h | 7 +++ qdev-monitor.c | 23

[Qemu-devel] [RFC PATCH 1/2] qemu-help: Sort devices by logical functionality

2013-07-18 Thread Marcel Apfelbaum
Categorize devices that appear as output to "-device ?" command by logical functionality. Sort the devices by logical categories before showing them to user. Signed-off-by: Marcel Apfelbaum Reviewed-by: Kevin Wolf --- include/hw/qdev-core.h | 7 +++ qdev-monitor.c | 23