Re: [Qemu-devel] [RFC PATCH 1/3] tcg: Release tb_lock in the order acquired

2016-12-08 Thread Paolo Bonzini
On 07/12/2016 16:38, Pranith Kumar wrote: > > Hi Alex, > > Alex Bennée writes: > >> >> Do you have any numbers for this? The main reason being we are trying to >> avoid bouncing the lock too much and while this is cleaner it could >> cause more contention. > > I did not really consider

Re: [Qemu-devel] [RFC PATCH 1/3] tcg: Release tb_lock in the order acquired

2016-12-07 Thread Pranith Kumar
Hi Alex, Alex Bennée writes: > > Do you have any numbers for this? The main reason being we are trying to > avoid bouncing the lock too much and while this is cleaner it could > cause more contention. I did not really consider performance while cleaning this up. However, I looked closer and I

Re: [Qemu-devel] [RFC PATCH 1/3] tcg: Release tb_lock in the order acquired

2016-12-07 Thread Alex Bennée
Pranith Kumar writes: > We acquire mmap lock and tb lock in one order and release them in a > different order. This does not need to be that way. > > This patch was inspired by a previous patch by Emilio G. Cota >

[Qemu-devel] [RFC PATCH 1/3] tcg: Release tb_lock in the order acquired

2016-12-06 Thread Pranith Kumar
We acquire mmap lock and tb lock in one order and release them in a different order. This does not need to be that way. This patch was inspired by a previous patch by Emilio G. Cota (https://lists.gnu.org/archive/html/qemu-devel/2016-08/msg03785.html). Signed-off-by: Pranith Kumar