Re: [Qemu-devel] [RFC PATCH 1/6] target/ppc: introduce get_fpr() and set_fpr() helpers for FP register access

2018-12-11 Thread Mark Cave-Ayland
On 10/12/2018 18:43, Richard Henderson wrote: > On 12/7/18 2:56 AM, Mark Cave-Ayland wrote: >> -gen_helper_f##op(cpu_fpr[rD(ctx->opcode)], cpu_env, >> \ >> - cpu_fpr[rA(ctx->opcode)], >> \ >> -

Re: [Qemu-devel] [RFC PATCH 1/6] target/ppc: introduce get_fpr() and set_fpr() helpers for FP register access

2018-12-11 Thread Mark Cave-Ayland
On 10/12/2018 05:17, David Gibson wrote: > On Fri, Dec 07, 2018 at 08:56:30AM +, Mark Cave-Ayland wrote: >> These helpers allow us to move FP register values to/from the specified >> TCGv_i64 >> argument. >> >> To prevent FP helpers accessing the cpu_fpr array directly, add extra TCG >>

Re: [Qemu-devel] [RFC PATCH 1/6] target/ppc: introduce get_fpr() and set_fpr() helpers for FP register access

2018-12-10 Thread David Gibson
On Mon, Dec 10, 2018 at 12:25:26PM -0600, Richard Henderson wrote: > On 12/9/18 11:17 PM, David Gibson wrote: > > On Fri, Dec 07, 2018 at 08:56:30AM +, Mark Cave-Ayland wrote: > >> These helpers allow us to move FP register values to/from the specified > >> TCGv_i64 > >> argument. > >> > >>

Re: [Qemu-devel] [RFC PATCH 1/6] target/ppc: introduce get_fpr() and set_fpr() helpers for FP register access

2018-12-10 Thread Richard Henderson
On 12/7/18 2:56 AM, Mark Cave-Ayland wrote: > -gen_helper_f##op(cpu_fpr[rD(ctx->opcode)], cpu_env, > \ > - cpu_fpr[rA(ctx->opcode)], > \ > - cpu_fpr[rC(ctx->opcode)], cpu_fpr[rB(ctx->opcode)]); >

Re: [Qemu-devel] [RFC PATCH 1/6] target/ppc: introduce get_fpr() and set_fpr() helpers for FP register access

2018-12-10 Thread Richard Henderson
On 12/9/18 11:17 PM, David Gibson wrote: > On Fri, Dec 07, 2018 at 08:56:30AM +, Mark Cave-Ayland wrote: >> These helpers allow us to move FP register values to/from the specified >> TCGv_i64 >> argument. >> >> To prevent FP helpers accessing the cpu_fpr array directly, add extra TCG >>

Re: [Qemu-devel] [RFC PATCH 1/6] target/ppc: introduce get_fpr() and set_fpr() helpers for FP register access

2018-12-09 Thread David Gibson
On Fri, Dec 07, 2018 at 08:56:30AM +, Mark Cave-Ayland wrote: > These helpers allow us to move FP register values to/from the specified > TCGv_i64 > argument. > > To prevent FP helpers accessing the cpu_fpr array directly, add extra TCG > temporaries as required. It's not obvious to me why

[Qemu-devel] [RFC PATCH 1/6] target/ppc: introduce get_fpr() and set_fpr() helpers for FP register access

2018-12-07 Thread Mark Cave-Ayland
These helpers allow us to move FP register values to/from the specified TCGv_i64 argument. To prevent FP helpers accessing the cpu_fpr array directly, add extra TCG temporaries as required. Signed-off-by: Mark Cave-Ayland --- target/ppc/translate.c | 10 +