Re: [Qemu-devel] [RFC PATCH 11/11] [WIP] block: Implement 'blockdev-add' QMP command

2013-07-12 Thread Kevin Wolf
Am 12.07.2013 um 00:45 hat Eric Blake geschrieben: On 07/09/2013 03:53 AM, Kevin Wolf wrote: This is just a quick hack to test things The rest of the series is mostly good to go, but not worth pushing until this is flushed out. But I love where it's headed! Glad to hear this!

Re: [Qemu-devel] [RFC PATCH 11/11] [WIP] block: Implement 'blockdev-add' QMP command

2013-07-12 Thread Eric Blake
On 07/12/2013 03:40 AM, Kevin Wolf wrote: + +{ 'command': 'blockdev-add', 'data': { 'options': 'BlockOptions' } } Sounds nice - and seems like it should be easy enough to extend BlockRef and/or BlockOptions to have a way to pass an fd even for backing files, getting to (my) end goal of

Re: [Qemu-devel] [RFC PATCH 11/11] [WIP] block: Implement 'blockdev-add' QMP command

2013-07-11 Thread Eric Blake
On 07/09/2013 03:53 AM, Kevin Wolf wrote: This is just a quick hack to test things The rest of the series is mostly good to go, but not worth pushing until this is flushed out. But I love where it's headed! Signed-off-by: Kevin Wolf kw...@redhat.com --- blockdev.c | 32

[Qemu-devel] [RFC PATCH 11/11] [WIP] block: Implement 'blockdev-add' QMP command

2013-07-09 Thread Kevin Wolf
This is just a quick hack to test things Signed-off-by: Kevin Wolf kw...@redhat.com --- blockdev.c | 32 qapi-schema.json | 29 + qmp-commands.hx | 6 ++ 3 files changed, 67 insertions(+) diff --git a/blockdev.c