Re: [Qemu-devel] [RFC PATCH 12/12] slirp: use HOST_SUPPORTS_UNALIGNED_ACCESS

2018-01-09 Thread Samuel Thibault
Philippe Mathieu-Daudé, on lun. 08 janv. 2018 14:29:04 -0300, wrote: > Access struct in6_addr with 'void *', then cast to 'u8 *' to avoid alignment > issues. Err, I don't understand the point. in6_addr's s6_addr is already a uint8_t by the standard. There is no non-byte access in the existing cod

Re: [Qemu-devel] [RFC PATCH 12/12] slirp: use HOST_SUPPORTS_UNALIGNED_ACCESS

2018-01-09 Thread Paolo Bonzini
On 08/01/2018 18:29, Philippe Mathieu-Daudé wrote: > Access struct in6_addr with 'void *', then cast to 'u8 *' to avoid alignment > issues. > > Signed-off-by: Philippe Mathieu-Daudé > --- > ugly... > > slirp/ip6.h | 58 ++ > 1 file changed

[Qemu-devel] [RFC PATCH 12/12] slirp: use HOST_SUPPORTS_UNALIGNED_ACCESS

2018-01-08 Thread Philippe Mathieu-Daudé
Access struct in6_addr with 'void *', then cast to 'u8 *' to avoid alignment issues. Signed-off-by: Philippe Mathieu-Daudé --- ugly... slirp/ip6.h | 58 ++ 1 file changed, 58 insertions(+) diff --git a/slirp/ip6.h b/slirp/ip6.h index c649