Re: [Qemu-devel] [RFC PATCH 3/7] error reporting: Use error_report_errno in obvious places

2018-04-26 Thread Eric Blake
On 04/26/2018 12:43 PM, Ian Jackson wrote: > Eric Blake writes ("Re: [RFC PATCH 3/7] error reporting: Use > error_report_errno in obvious places"): >> Misses a lot of two-line instances, such as: >> $ git grep -A1 error_report | grep -C1 strerror.errno >> ... > ... >> If we're going to clean up th

Re: [Qemu-devel] [RFC PATCH 3/7] error reporting: Use error_report_errno in obvious places

2018-04-26 Thread Ian Jackson
Eric Blake writes ("Re: [RFC PATCH 3/7] error reporting: Use error_report_errno in obvious places"): > Misses a lot of two-line instances, such as: > $ git grep -A1 error_report | grep -C1 strerror.errno > ... ... > If we're going to clean up these instances, we might as well look harder > for the

Re: [Qemu-devel] [RFC PATCH 3/7] error reporting: Use error_report_errno in obvious places

2018-04-26 Thread Eric Blake
On 04/26/2018 11:53 AM, Ian Jackson wrote: > This patch is the result of > > git-grep -l 'error_report.*strerror' | xargs perl -p -i~ ../t > > with ../t containing > > s{error_report\("(.*): \%s"(, .*)?, > strerror\(errno\)\)\;}{error_report_errno\("$1"$2)\;} > > Since this is an automatic

[Qemu-devel] [RFC PATCH 3/7] error reporting: Use error_report_errno in obvious places

2018-04-26 Thread Ian Jackson
This patch is the result of git-grep -l 'error_report.*strerror' | xargs perl -p -i~ ../t with ../t containing s{error_report\("(.*): \%s"(, .*)?, strerror\(errno\)\)\;}{error_report_errno\("$1"$2)\;} Since this is an automatically generated patch, it does not contain any cleanups of the o