Re: [Qemu-devel] [RFC PATCH 6/7] net/eepro100: reduce alignment to DWORD (32bit)

2018-01-08 Thread Philippe Mathieu-Daudé
On 01/08/2018 03:10 PM, Paolo Bonzini wrote: > On 08/01/2018 19:02, Philippe Mathieu-Daudé wrote: >> /* Data in mem is always in the byte order of the controller (le). >> * It must be dword aligned to allow direct access to 32 bit values. */ >> -uint8_t mem[PCI_MEM_SIZE] QEMU_ALIGNED

Re: [Qemu-devel] [RFC PATCH 6/7] net/eepro100: reduce alignment to DWORD (32bit)

2018-01-08 Thread Paolo Bonzini
On 08/01/2018 19:02, Philippe Mathieu-Daudé wrote: > /* Data in mem is always in the byte order of the controller (le). > * It must be dword aligned to allow direct access to 32 bit values. */ > -uint8_t mem[PCI_MEM_SIZE] QEMU_ALIGNED(8); > +uint8_t mem[PCI_MEM_SIZE] QEMU_ALIGNED

[Qemu-devel] [RFC PATCH 6/7] net/eepro100: reduce alignment to DWORD (32bit)

2018-01-08 Thread Philippe Mathieu-Daudé
as suggested in the comment. Signed-off-by: Philippe Mathieu-Daudé --- hw/net/eepro100.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/eepro100.c b/hw/net/eepro100.c index 61d767524f..abb44710d9 100644 --- a/hw/net/eepro100.c +++ b/hw/net/eepro100.c @@ -266,7 +266,7