Re: [Qemu-devel] [RFC PATCH RDMA support v1: 5/5] send memory over RDMA as blocks are iterated

2013-02-01 Thread Michael R. hines
Excellent, thank you. On 02/01/2013 05:01 AM, Orit Wasserman wrote: On 01/31/2013 09:10 PM, Michael R. hines wrote: Sorry, I didn't go into enough detail about the problem I'm having in the loop: The loop that's not breaking is inside qemu_loadvm_state(), not ram_save_block(). I understand n

Re: [Qemu-devel] [RFC PATCH RDMA support v1: 5/5] send memory over RDMA as blocks are iterated

2013-02-01 Thread Orit Wasserman
On 01/31/2013 09:10 PM, Michael R. hines wrote: > Sorry, I didn't go into enough detail about the problem I'm having in the > loop: > > The loop that's not breaking is inside qemu_loadvm_state(), not > ram_save_block(). I understand now, ram_load always read the addr in the begining of the while

Re: [Qemu-devel] [RFC PATCH RDMA support v1: 5/5] send memory over RDMA as blocks are iterated

2013-01-31 Thread Michael R. hines
Sorry, I didn't go into enough detail about the problem I'm having in the loop: The loop that's not breaking is inside qemu_loadvm_state(), not ram_save_block(). This do-while loop is not exiting... is it necessary for me to maintain this loop for RDMA purposes? Since there is explicit

Re: [Qemu-devel] [RFC PATCH RDMA support v1: 5/5] send memory over RDMA as blocks are iterated

2013-01-31 Thread Orit Wasserman
On 01/31/2013 05:08 PM, Michael R. hines wrote: > Yes, I was hoping for a comment about this in particular (before I send out > another patchest with the proper coverletter and so forth). > > So here's the problem I was experiencing inside savevm.c, qemu_loadvm_state(): > > I was having a little

Re: [Qemu-devel] [RFC PATCH RDMA support v1: 5/5] send memory over RDMA as blocks are iterated

2013-01-31 Thread Michael R. hines
Yes, I was hoping for a comment about this in particular (before I send out another patchest with the proper coverletter and so forth). So here's the problem I was experiencing inside savevm.c, qemu_loadvm_state(): I was having a little trouble serializing the client/server protocol in my br

Re: [Qemu-devel] [RFC PATCH RDMA support v1: 5/5] send memory over RDMA as blocks are iterated

2013-01-31 Thread Orit Wasserman
Hi Michael, I maybe missing something here but why do you need a RAM_SAVE_FLAG_RDMA flag? You don't do any decoding in the destination. I would suggest creating a QEMUFileRDMA and moving the write/read code You can either add a new rdma_buffer QEMUFileOps or add the address to put_buffer. you al

[Qemu-devel] [RFC PATCH RDMA support v1: 5/5] send memory over RDMA as blocks are iterated

2013-01-28 Thread mrhines
From: "Michael R. Hines" Signed-off-by: Michael R. Hines --- arch_init.c | 116 +++-- include/migration/qemu-file.h |1 + savevm.c | 90 +++- 3 files changed, 189 insertions(+), 18 del