Re: [Qemu-devel] [RFC PATCH V2 2/3] cpus: add a tcg_executing flag.

2015-07-15 Thread Frederic Konrad
On 13/07/2015 17:56, Alex Bennée wrote: fred.kon...@greensocs.com writes: From: KONRAD Frederic This flag indicates if the VCPU is currently executing TCG code. Signed-off-by: KONRAD Frederic Changes V1 -> V2: * do both tcg_executing = 0 or 1 in cpu_exec(). --- cpu-exec.c| 2 +

Re: [Qemu-devel] [RFC PATCH V2 2/3] cpus: add a tcg_executing flag.

2015-07-13 Thread Alex Bennée
Paolo Bonzini writes: > On 13/07/2015 18:10, Peter Maydell wrote: >> (4) a few other things which are suspicious at best: >> hw/intc/apic_common.c:volatile int a_i_d = apic_irq_delivered; > > This one has a comment above: > > /* Copy this into a local variable to encourage gcc to emit

Re: [Qemu-devel] [RFC PATCH V2 2/3] cpus: add a tcg_executing flag.

2015-07-13 Thread Paolo Bonzini
On 13/07/2015 18:10, Peter Maydell wrote: > (4) a few other things which are suspicious at best: > hw/intc/apic_common.c:volatile int a_i_d = apic_irq_delivered; This one has a comment above: /* Copy this into a local variable to encourage gcc to emit a plain * register for a sy

Re: [Qemu-devel] [RFC PATCH V2 2/3] cpus: add a tcg_executing flag.

2015-07-13 Thread Peter Maydell
On 13 July 2015 at 16:56, Alex Bennée wrote: >> From: KONRAD Frederic >> @@ -322,6 +323,8 @@ struct CPUState { >> (absolute value) offset as small as possible. This reduces code >> size, especially for hosts without large memory offsets. */ >> volatile sig_atomic_t tcg_exit

Re: [Qemu-devel] [RFC PATCH V2 2/3] cpus: add a tcg_executing flag.

2015-07-13 Thread Alex Bennée
fred.kon...@greensocs.com writes: > From: KONRAD Frederic > > This flag indicates if the VCPU is currently executing TCG code. > > Signed-off-by: KONRAD Frederic > > Changes V1 -> V2: > * do both tcg_executing = 0 or 1 in cpu_exec(). > --- > cpu-exec.c| 2 ++ > include/qom/cpu.h | 3

[Qemu-devel] [RFC PATCH V2 2/3] cpus: add a tcg_executing flag.

2015-07-10 Thread fred . konrad
From: KONRAD Frederic This flag indicates if the VCPU is currently executing TCG code. Signed-off-by: KONRAD Frederic Changes V1 -> V2: * do both tcg_executing = 0 or 1 in cpu_exec(). --- cpu-exec.c| 2 ++ include/qom/cpu.h | 3 +++ qom/cpu.c | 1 + 3 files changed, 6 insert