[Qemu-devel] [RFC PATCH V3 1/4] colo-compare: introduce colo compare initlization

2016-04-18 Thread Zhang Chen
packet come from primary char indev will be send to outdev - packet come from secondary char dev will be drop usage: primary: -netdev tap,id=hn0,vhost=off,script=/etc/qemu-ifup,downscript=/etc/qemu-ifdown -device e1000,id=e0,netdev=hn0,mac=52:a4:00:12:78:66 -chardev socket,id=mirror0,host=3.3.3.3

Re: [Qemu-devel] [RFC PATCH V3 1/4] colo-compare: introduce colo compare initlization

2016-05-19 Thread Jason Wang
On 2016年05月13日 11:48, Jason Wang wrote: On 2016年05月12日 16:16, Zhang Chen wrote: On 05/12/2016 04:01 PM, Jason Wang wrote: On 2016年05月12日 14:49, Zhang Chen wrote: On 05/09/2016 06:49 PM, Zhang Chen wrote: + +s->chr_sec_in = qemu_chr_find(s->sec_indev); +if (s->chr_sec_in ==

Re: [Qemu-devel] [RFC PATCH V3 1/4] colo-compare: introduce colo compare initlization

2016-05-19 Thread Fam Zheng
On Fri, 05/20 10:46, Jason Wang wrote: > > > On 2016年05月13日 11:48, Jason Wang wrote: > > > > > > On 2016年05月12日 16:16, Zhang Chen wrote: > > > > > > > > > On 05/12/2016 04:01 PM, Jason Wang wrote: > > > > > > > > > > > > On 2016年05月12日 14:49, Zhang Chen wrote: > > > > > > > > > > > > > >

Re: [Qemu-devel] [RFC PATCH V3 1/4] colo-compare: introduce colo compare initlization

2016-05-05 Thread Zhang Chen
On 04/29/2016 10:03 AM, Jason Wang wrote: On 04/28/2016 05:04 PM, Zhang Chen wrote: On 04/28/2016 04:17 PM, Jason Wang wrote: On 04/28/2016 03:55 PM, Zhang Chen wrote: On 04/28/2016 03:16 PM, Jason Wang wrote: On 04/28/2016 02:53 PM, Jason Wang wrote: +static void compare_set_outdev(Obje

Re: [Qemu-devel] [RFC PATCH V3 1/4] colo-compare: introduce colo compare initlization

2016-05-05 Thread Jason Wang
On 05/06/2016 01:42 PM, Zhang Chen wrote: > > > On 04/29/2016 10:03 AM, Jason Wang wrote: >> >> On 04/28/2016 05:04 PM, Zhang Chen wrote: >>> >>> On 04/28/2016 04:17 PM, Jason Wang wrote: On 04/28/2016 03:55 PM, Zhang Chen wrote: > On 04/28/2016 03:16 PM, Jason Wang wrote: >> On 04/2

Re: [Qemu-devel] [RFC PATCH V3 1/4] colo-compare: introduce colo compare initlization

2016-05-09 Thread Zhang Chen
+ +s->chr_sec_in = qemu_chr_find(s->sec_indev); +if (s->chr_sec_in == NULL) { +error_setg(errp, "Secondary IN Device '%s' not found", + s->sec_indev); +return; +} + +s->chr_out = qemu_chr_find(s->outdev); +if (s->chr_out == NULL) { +e

Re: [Qemu-devel] [RFC PATCH V3 1/4] colo-compare: introduce colo compare initlization

2016-05-11 Thread Zhang Chen
On 05/09/2016 06:49 PM, Zhang Chen wrote: + +s->chr_sec_in = qemu_chr_find(s->sec_indev); +if (s->chr_sec_in == NULL) { +error_setg(errp, "Secondary IN Device '%s' not found", + s->sec_indev); +return; +} + +s->chr_out = qemu_chr_find(s->outde

Re: [Qemu-devel] [RFC PATCH V3 1/4] colo-compare: introduce colo compare initlization

2016-05-12 Thread Jason Wang
On 2016年05月12日 14:49, Zhang Chen wrote: On 05/09/2016 06:49 PM, Zhang Chen wrote: + +s->chr_sec_in = qemu_chr_find(s->sec_indev); +if (s->chr_sec_in == NULL) { +error_setg(errp, "Secondary IN Device '%s' not found", + s->sec_indev); +return; +}

Re: [Qemu-devel] [RFC PATCH V3 1/4] colo-compare: introduce colo compare initlization

2016-05-12 Thread Zhang Chen
On 05/12/2016 04:01 PM, Jason Wang wrote: On 2016年05月12日 14:49, Zhang Chen wrote: On 05/09/2016 06:49 PM, Zhang Chen wrote: + +s->chr_sec_in = qemu_chr_find(s->sec_indev); +if (s->chr_sec_in == NULL) { +error_setg(errp, "Secondary IN Device '%s' not found", +

Re: [Qemu-devel] [RFC PATCH V3 1/4] colo-compare: introduce colo compare initlization

2016-05-12 Thread Jason Wang
On 2016年05月12日 16:16, Zhang Chen wrote: On 05/12/2016 04:01 PM, Jason Wang wrote: On 2016年05月12日 14:49, Zhang Chen wrote: On 05/09/2016 06:49 PM, Zhang Chen wrote: + +s->chr_sec_in = qemu_chr_find(s->sec_indev); +if (s->chr_sec_in == NULL) { +error_setg(errp, "Seconda

Re: [Qemu-devel] [RFC PATCH V3 1/4] colo-compare: introduce colo compare initlization

2016-04-27 Thread Jason Wang
On 04/18/2016 07:11 PM, Zhang Chen wrote: > packet come from primary char indev will be send to > outdev - packet come from secondary char dev will be drop > > usage: > > primary: > -netdev tap,id=hn0,vhost=off,script=/etc/qemu-ifup,downscript=/etc/qemu-ifdown > -device e1000,id=e0,netdev=hn0,mac

Re: [Qemu-devel] [RFC PATCH V3 1/4] colo-compare: introduce colo compare initlization

2016-04-28 Thread Jason Wang
On 04/28/2016 02:53 PM, Jason Wang wrote: > +static void compare_set_outdev(Object *obj, const char *value, Error **errp) > > +{ > > +CompareState *s = COLO_COMPARE(obj); > > + > > +g_free(s->outdev); > > +s->outdev = g_strdup(value); > > +} > > + > > +/* > > + * called from the main

Re: [Qemu-devel] [RFC PATCH V3 1/4] colo-compare: introduce colo compare initlization

2016-04-28 Thread Zhang Chen
On 04/28/2016 02:53 PM, Jason Wang wrote: On 04/18/2016 07:11 PM, Zhang Chen wrote: packet come from primary char indev will be send to outdev - packet come from secondary char dev will be drop usage: primary: -netdev tap,id=hn0,vhost=off,script=/etc/qemu-ifup,downscript=/etc/qemu-ifdown -d

Re: [Qemu-devel] [RFC PATCH V3 1/4] colo-compare: introduce colo compare initlization

2016-04-28 Thread Zhang Chen
On 04/28/2016 03:16 PM, Jason Wang wrote: On 04/28/2016 02:53 PM, Jason Wang wrote: +static void compare_set_outdev(Object *obj, const char *value, Error **errp) +{ +CompareState *s = COLO_COMPARE(obj); + +g_free(s->outdev); +s->outdev = g_strdup(value); +} + +/* + * called from

Re: [Qemu-devel] [RFC PATCH V3 1/4] colo-compare: introduce colo compare initlization

2016-04-28 Thread Jason Wang
On 04/28/2016 03:55 PM, Zhang Chen wrote: > > > On 04/28/2016 03:16 PM, Jason Wang wrote: >> >> On 04/28/2016 02:53 PM, Jason Wang wrote: >>> +static void compare_set_outdev(Object *obj, const char *value, >>> Error **errp) +{ +CompareState *s = COLO_COMPARE(obj); + +g

Re: [Qemu-devel] [RFC PATCH V3 1/4] colo-compare: introduce colo compare initlization

2016-04-28 Thread Jason Wang
On 04/28/2016 03:53 PM, Zhang Chen wrote: > > > On 04/28/2016 02:53 PM, Jason Wang wrote: >> >> On 04/18/2016 07:11 PM, Zhang Chen wrote: >>> packet come from primary char indev will be send to >>> outdev - packet come from secondary char dev will be drop >>> >>> usage: >>> >>> primary: >>> -netd

Re: [Qemu-devel] [RFC PATCH V3 1/4] colo-compare: introduce colo compare initlization

2016-04-28 Thread Zhang Chen
On 04/28/2016 04:17 PM, Jason Wang wrote: On 04/28/2016 03:55 PM, Zhang Chen wrote: On 04/28/2016 03:16 PM, Jason Wang wrote: On 04/28/2016 02:53 PM, Jason Wang wrote: +static void compare_set_outdev(Object *obj, const char *value, Error **errp) +{ +CompareState *s = COLO_COMPARE(obj)

Re: [Qemu-devel] [RFC PATCH V3 1/4] colo-compare: introduce colo compare initlization

2016-04-28 Thread Eric Blake
On 04/18/2016 05:11 AM, Zhang Chen wrote: s/initlization/initialization/ in the subject > packet come from primary char indev will be send to > outdev - packet come from secondary char dev will be drop Grammar suggestion: Packets coming from the primary char indev will be sent to outdev; packet

Re: [Qemu-devel] [RFC PATCH V3 1/4] colo-compare: introduce colo compare initlization

2016-04-28 Thread Zhang Chen
On 04/29/2016 04:55 AM, Eric Blake wrote: On 04/18/2016 05:11 AM, Zhang Chen wrote: s/initlization/initialization/ in the subject OK~ packet come from primary char indev will be send to outdev - packet come from secondary char dev will be drop Grammar suggestion: Packets coming from the

Re: [Qemu-devel] [RFC PATCH V3 1/4] colo-compare: introduce colo compare initlization

2016-04-28 Thread Jason Wang
On 04/28/2016 05:04 PM, Zhang Chen wrote: > > > On 04/28/2016 04:17 PM, Jason Wang wrote: >> >> On 04/28/2016 03:55 PM, Zhang Chen wrote: >>> >>> On 04/28/2016 03:16 PM, Jason Wang wrote: On 04/28/2016 02:53 PM, Jason Wang wrote: > +static void compare_set_outdev(Object *obj, const char

Re: [Qemu-devel] [RFC PATCH V3 1/4] colo-compare: introduce colo compare initlization

2016-04-28 Thread Zhang Chen
On 04/29/2016 10:03 AM, Jason Wang wrote: On 04/28/2016 05:04 PM, Zhang Chen wrote: On 04/28/2016 04:17 PM, Jason Wang wrote: On 04/28/2016 03:55 PM, Zhang Chen wrote: On 04/28/2016 03:16 PM, Jason Wang wrote: On 04/28/2016 02:53 PM, Jason Wang wrote: +static void compare_set_outdev(Obje