Re: [Qemu-devel] [RFC PATCH V7 11/19] tcg: switch on multithread.

2015-08-13 Thread Frederic Konrad
On 13/08/2015 16:58, Paolo Bonzini wrote: On 13/08/2015 16:41, Frederic Konrad wrote: One issue here is that when tcg_cpu_exec returns EXCP_HALTED, the function keeps looping. There is no need to set cpu->exit_request in that case, since in fact there is no request pending, so the while loop p

Re: [Qemu-devel] [RFC PATCH V7 11/19] tcg: switch on multithread.

2015-08-13 Thread Paolo Bonzini
On 13/08/2015 16:41, Frederic Konrad wrote: >>> >> One issue here is that when tcg_cpu_exec returns EXCP_HALTED, the >> function keeps looping. There is no need to set cpu->exit_request in >> that case, since in fact there is no request pending, so the while loop >> probably should be an "if". >

Re: [Qemu-devel] [RFC PATCH V7 11/19] tcg: switch on multithread.

2015-08-13 Thread Frederic Konrad
On 13/08/2015 13:17, Paolo Bonzini wrote: On 10/08/2015 17:27, fred.kon...@greensocs.com wrote: +while (!cpu->exit_request) { qemu_clock_enable(QEMU_CLOCK_VIRTUAL, (cpu->singlestep_enabled & SSTEP_NOTIMER) == 0); @@ -1507,7 +1480,7 @@ static void tcg

Re: [Qemu-devel] [RFC PATCH V7 11/19] tcg: switch on multithread.

2015-08-13 Thread Paolo Bonzini
On 10/08/2015 17:27, fred.kon...@greensocs.com wrote: > +while (!cpu->exit_request) { > qemu_clock_enable(QEMU_CLOCK_VIRTUAL, >(cpu->singlestep_enabled & SSTEP_NOTIMER) == 0); > > @@ -1507,7 +1480,7 @@ static void tcg_exec_all(void) > } > }

[Qemu-devel] [RFC PATCH V7 11/19] tcg: switch on multithread.

2015-08-10 Thread fred . konrad
From: KONRAD Frederic This switches on multithread. Signed-off-by: KONRAD Frederic Changes V5 -> V6: * make qemu_cpu_kick calling qemu_cpu_kick_thread in case of TCG. --- cpus.c | 93 -- 1 file changed, 33 insertions(+), 60 del