Re: [Qemu-devel] [RFC PATCH v2 00/16] visitor+BER migration format

2014-05-07 Thread Michael S. Tsirkin
On Wed, Apr 23, 2014 at 12:57:43PM -0600, Eric Blake wrote: > On 04/23/2014 11:54 AM, Michael S. Tsirkin wrote: > > On Wed, Apr 23, 2014 at 11:47:21AM -0600, Eric Blake wrote: > >> On 04/23/2014 11:16 AM, Dr. David Alan Gilbert wrote: > >>> The one thing that the environment variable does make nice

Re: [Qemu-devel] [RFC PATCH v2 00/16] visitor+BER migration format

2014-05-07 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > "Michael S. Tsirkin" writes: > > > On Tue, May 06, 2014 at 07:58:07PM +0100, Dr. David Alan Gilbert wrote: > >> * Markus Armbruster (arm...@redhat.com) wrote: > >> > "Michael S. Tsirkin" writes: > >> > >> > >> > >> > > OK but for a new machine

Re: [Qemu-devel] [RFC PATCH v2 00/16] visitor+BER migration format

2014-05-06 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > On Tue, May 06, 2014 at 07:58:07PM +0100, Dr. David Alan Gilbert wrote: >> * Markus Armbruster (arm...@redhat.com) wrote: >> > "Michael S. Tsirkin" writes: >> >> >> >> > > OK but for a new machine type, let's default to BER, right? >> > > I see no reason to keep

Re: [Qemu-devel] [RFC PATCH v2 00/16] visitor+BER migration format

2014-05-06 Thread Michael S. Tsirkin
On Tue, May 06, 2014 at 07:58:07PM +0100, Dr. David Alan Gilbert wrote: > * Markus Armbruster (arm...@redhat.com) wrote: > > "Michael S. Tsirkin" writes: > > > > > > OK but for a new machine type, let's default to BER, right? > > > I see no reason to keep supporting when non-BER when -M specifi

Re: [Qemu-devel] [RFC PATCH v2 00/16] visitor+BER migration format

2014-05-06 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > "Michael S. Tsirkin" writes: > > OK but for a new machine type, let's default to BER, right? > > I see no reason to keep supporting when non-BER when -M specifies 2.1 > > compatibility, do you? > > I fail to see the relation between machine type

Re: [Qemu-devel] [RFC PATCH v2 00/16] visitor+BER migration format

2014-04-25 Thread Eric Blake
On 04/24/2014 02:21 AM, Dr. David Alan Gilbert wrote: >> Sounds like a useful hack to speed up development, but not so much like >> a useful permanent API :) > > Yep, I think what I'll do is go with Eric's suggestion of the > migration-capability, > but initialise it based on the environment var

Re: [Qemu-devel] [RFC PATCH v2 00/16] visitor+BER migration format

2014-04-25 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > On Thu, Apr 24, 2014 at 09:21:00AM +0100, Dr. David Alan Gilbert wrote: >> * Markus Armbruster (arm...@redhat.com) wrote: >> > "Dr. David Alan Gilbert" writes: >> > >> > > * Eric Blake (ebl...@redhat.com) wrote: >> > >> On 04/23/2014 10:37 AM, Dr. David Alan Gilbe

Re: [Qemu-devel] [RFC PATCH v2 00/16] visitor+BER migration format

2014-04-24 Thread Michael S. Tsirkin
On Thu, Apr 24, 2014 at 09:21:00AM +0100, Dr. David Alan Gilbert wrote: > * Markus Armbruster (arm...@redhat.com) wrote: > > "Dr. David Alan Gilbert" writes: > > > > > * Eric Blake (ebl...@redhat.com) wrote: > > >> On 04/23/2014 10:37 AM, Dr. David Alan Gilbert (git) wrote: > > >> > From: "Dr. Da

Re: [Qemu-devel] [RFC PATCH v2 00/16] visitor+BER migration format

2014-04-24 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > "Dr. David Alan Gilbert" writes: > > > * Eric Blake (ebl...@redhat.com) wrote: > >> On 04/23/2014 10:37 AM, Dr. David Alan Gilbert (git) wrote: > >> > From: "Dr. David Alan Gilbert" > >> > > >> > >> >4) At the moment you select BER output fo

Re: [Qemu-devel] [RFC PATCH v2 00/16] visitor+BER migration format

2014-04-24 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Eric Blake (ebl...@redhat.com) wrote: >> On 04/23/2014 10:37 AM, Dr. David Alan Gilbert (git) wrote: >> > From: "Dr. David Alan Gilbert" >> > >> >> >4) At the moment you select BER output format by setting an environment >> > variable ( export QEM

Re: [Qemu-devel] [RFC PATCH v2 00/16] visitor+BER migration format

2014-04-23 Thread Eric Blake
On 04/23/2014 11:54 AM, Michael S. Tsirkin wrote: > On Wed, Apr 23, 2014 at 11:47:21AM -0600, Eric Blake wrote: >> On 04/23/2014 11:16 AM, Dr. David Alan Gilbert wrote: >>> The one thing that the environment variable does make nice and easy, >>> for dev, is using it with existing test setups - e.g.

Re: [Qemu-devel] [RFC PATCH v2 00/16] visitor+BER migration format

2014-04-23 Thread Michael S. Tsirkin
On Wed, Apr 23, 2014 at 11:47:21AM -0600, Eric Blake wrote: > On 04/23/2014 11:16 AM, Dr. David Alan Gilbert wrote: > > The one thing that the environment variable does make nice and easy, > > for dev, is using it with existing test setups - e.g. running virt-test > > in BER mode or existing mode.

Re: [Qemu-devel] [RFC PATCH v2 00/16] visitor+BER migration format

2014-04-23 Thread Eric Blake
On 04/23/2014 11:16 AM, Dr. David Alan Gilbert wrote: > The one thing that the environment variable does make nice and easy, > for dev, is using it with existing test setups - e.g. running virt-test > in BER mode or existing mode. Hmm. Maybe a compromise - an environment variable determines the de

Re: [Qemu-devel] [RFC PATCH v2 00/16] visitor+BER migration format

2014-04-23 Thread Michael S. Tsirkin
On Wed, Apr 23, 2014 at 06:16:23PM +0100, Dr. David Alan Gilbert wrote: > * Eric Blake (ebl...@redhat.com) wrote: > > On 04/23/2014 10:37 AM, Dr. David Alan Gilbert (git) wrote: > > > From: "Dr. David Alan Gilbert" > > > > > > > >4) At the moment you select BER output format by setting an en

Re: [Qemu-devel] [RFC PATCH v2 00/16] visitor+BER migration format

2014-04-23 Thread Dr. David Alan Gilbert
* Eric Blake (ebl...@redhat.com) wrote: > On 04/23/2014 10:37 AM, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > >4) At the moment you select BER output format by setting an environment > > variable ( export QEMUMIGFORMAT=BER ) , I need to put more thoug

[Qemu-devel] [RFC PATCH v2 00/16] visitor+BER migration format

2014-04-23 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" This is the 2nd version of my work-in-progress cut of my visitor+BER format migration world; there's lots to do but it's starting to get there. I'd appreciate if anyone who has more experience with either the visitor code, or ASN.1/BER in general has a look to see i

Re: [Qemu-devel] [RFC PATCH v2 00/16] visitor+BER migration format

2014-04-23 Thread Eric Blake
On 04/23/2014 10:37 AM, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > >4) At the moment you select BER output format by setting an environment > variable ( export QEMUMIGFORMAT=BER ) , I need to put more thought > in to the right way to do this, there are